Closed
Bug 913268
Opened 11 years ago
Closed 11 years ago
Make CPP_SOURCES a StrictOrderingOnAppendList
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla27
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Whiteboard: [good first bug])
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
(deleted),
text/plain
|
Details |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
I only went halfway through. I don't feel like finishing this myself.
Assignee | ||
Updated•11 years ago
|
Whiteboard: [good first bug]
Updated•11 years ago
|
Assignee: nobody → Ms2ger
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #820981 -
Flags: review?(mshal)
Assignee | ||
Updated•11 years ago
|
Attachment #800480 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Assignee: Ms2ger → mh+mozilla
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•11 years ago
|
||
Refreshed against current m-i.
Attachment #820982 -
Flags: review?(mshal)
Assignee | ||
Updated•11 years ago
|
Attachment #820981 -
Attachment is obsolete: true
Attachment #820981 -
Flags: review?(mshal)
Assignee | ||
Comment 4•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #820983 -
Attachment mime type: text/x-python → text/plain
Comment 5•11 years ago
|
||
Comment on attachment 820982 [details] [diff] [review]
Make CPP_SOURCES a StrictOrderingOnAppendList
Looks good to me! Is try happy? I seem to remember hitting some orange tests when trying to sort CPP_SOURCES originally.
Attachment #820982 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•