Closed
Bug 921492
Opened 11 years ago
Closed 11 years ago
make StrictOrderingOnAppendList use actual alphabetical sorting
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla27
People
(Reporter: froydnj, Assigned: glandium)
References
Details
Attachments
(2 files, 1 obsolete file)
In fixing bug 921091, I was surprised that moz.build wanted the ordering:
CDATA<stuff>.webidl
CallEvent.webidl
instead of the expected alphabetical ordering. I know why it wants this, but I submit that it is unusual.
In some ways, this is moot because moz.build tells you how to fix things (++ for that). But it might be better to not have to fix things in the first place.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #821013 -
Flags: review?(mshal)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•11 years ago
|
||
Assignee | ||
Comment 3•11 years ago
|
||
gps for the sandbox change. Sadly, overloading __builtins__.list doesn't make literal lists ("[1,2,3]") use the overloaded class, which means it's hard to do the same with list.sort().
Attachment #821022 -
Flags: review?(mshal)
Attachment #821022 -
Flags: review?(gps)
Assignee | ||
Updated•11 years ago
|
Attachment #821013 -
Attachment is obsolete: true
Attachment #821013 -
Flags: review?(mshal)
Comment 4•11 years ago
|
||
Comment on attachment 821022 [details] [diff] [review]
Make StrictOrderingOnAppendList use actual alphabetical sorting
>+ 'PSMContentListener.cpp',
nit: tab instead of spaces
Also, your script seems to preserve comments with the line they were on rather than the filename, so dom/mobilemessage/src/moz.build gets a bit messed up:
- 'MobileMessageService.h', # Required by nsLayoutModule.cpp
- 'SmsServicesFactory.h', # Required by nsLayoutModule.cpp
- 'Types.h', # Required by IPDL SmsTypes.h
- 'ipc/SmsChild.h',
- 'ipc/SmsParent.h',
+ 'ipc/SmsChild.h', # Required by nsLayoutModule.cpp
+ 'ipc/SmsParent.h', # Required by nsLayoutModule.cpp
+ 'MobileMessageService.h', # Required by IPDL SmsTypes.h
+ 'SmsServicesFactory.h',
+ 'Types.h',
Eg: MobileMessageService.h used to say "Required by nsLayoutModule.cpp", but now says "Required by IPDL SmsTypes.h"
Attachment #821022 -
Flags: review?(mshal) → review+
Updated•11 years ago
|
Attachment #821022 -
Flags: review?(gps) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•