Open
Bug 913869
Opened 11 years ago
Updated 2 years ago
Trim BindingUtils.h some more
Categories
(Core :: DOM: Core & HTML, defect, P5)
Core
DOM: Core & HTML
Tracking
()
NEW
People
(Reporter: bjacob, Unassigned)
References
(Blocks 1 open bug)
Details
Bug 909003 just made it a lot better.
We should still:
- stop including <algorithm> , see bug 913852
- stop including <nsThreadUtils.h>, see bug 913847 which makes us include a new MainThreadUtils.h instead,
- stop including that new MainThreadUtils.h, see bug 909971
- anything else?
Comment 1•11 years ago
|
||
Is BindingUtils.h really included by a lot of *headers*? I'd usually prefer avoiding including BindingUtils.h itself (outside of dom/bindings/).
Comment 2•11 years ago
|
||
According to my MXRing, the only real headers that include it are WebGLContextUtils.h and XPCQuickStubs.h.
Comment 3•11 years ago
|
||
The following generated headers include BindingUtils.h (directly); might be worth investigating if those are included too much.
AudioContextBinding.h
DOMMMIErrorBinding.h
DOMTransactionBinding.h
EventHandlerBinding.h
EventListenerBinding.h
FunctionBinding.h
FutureBinding.h
GeolocationBinding.h
MediaStreamEventBinding.h
MutationObserverBinding.h
NavigatorBinding.h
NodeFilterBinding.h
NotificationBinding.h
PhoneNumberServiceBinding.h
PromiseBinding.h
PushManagerBinding.h
RTCDataChannelEventBinding.h
RTCIceCandidateBinding.h
RTCPeerConnectionBinding.h
RTCPeerConnectionIceEventBinding.h
RTCSessionDescriptionBinding.h
SettingsManagerBinding.h
TestCodeGenBinding.h
TestJSImplGenBinding.h
TestJSImplInheritanceGenBinding.h
WebComponentsBinding.h
WindowBinding.h
Comment 4•11 years ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #2)
> According to my MXRing, the only real headers that include it are
> WebGLContextUtils.h and XPCQuickStubs.h.
I'm removing the latter in bug 913851.
Blocks: includehell
Depends on: 913851
Comment 5•11 years ago
|
||
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #4)
> (In reply to Andrew McCreight [:mccr8] from comment #2)
> > According to my MXRing, the only real headers that include it are
> > WebGLContextUtils.h and XPCQuickStubs.h.
>
> I'm removing the latter in bug 913851.
And the former actually needs the include, and isn't really included anywhere.
Comment 6•6 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046
Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.
If you have questions, please contact :mdaly.
Priority: -- → P5
Assignee | ||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•