Closed Bug 914079 Opened 11 years ago Closed 11 years ago

The whole pseudo elements bar should be clickable

Categories

(DevTools :: Inspector, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: rik, Assigned: pbro)

References

Details

Attachments

(1 file, 1 obsolete file)

Right now, only the arrow is clickable and that's a small target.
For info, I'm working on bug 913014 which aims at doing the same for the computed styles view. Also, bug 855523 should land shortly, and this one aims at doing the same too for the markup view. So it makes sense, for consistency reasons, whenever we have a horizontal container with an expand/collapse twisty, that the whole container also serves as an expand/collapse element. Having said this, both the markup and computed views are going to have it on dblclick, not click. Only the twisty is single clickable.
Assignee: nobody → pbrosset
Blocks: 835808
No longer blocks: 835808
Attached patch 914079-dblclick-pseudo.patch (obsolete) (deleted) — Splinter Review
This patch allows users to dblclick on the pseudo element header itself. The twisty remains clickable as before. This patch also contains an attempt for a mochitest browser test that I haven't been able to finalize. It's basically using the `EventUtils.sendMouseEvent({type:"dblclick"}...)` API which doesn't seem to work at all for me. Any help about why that might be would be great!
Attachment #802171 - Flags: review?(mratcliffe)
Attached patch 914079-dblclick-pseudo.patch (deleted) — Splinter Review
Uploading a new version of the same patch after having finally found a way to simulate double click events.
Attachment #802171 - Attachment is obsolete: true
Attachment #802171 - Flags: review?(mratcliffe)
Attachment #802239 - Flags: review?(mratcliffe)
Attachment #802239 - Flags: review?(mratcliffe) → review+
Thank you Mike for the review!
Whiteboard: [land-in-fx-team]
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: