Closed
Bug 915971
Opened 11 years ago
Closed 11 years ago
Rename "ReturnValue" unions to "Owning" unions
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
dzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #804191 -
Flags: review?(dzbarsky)
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [need review]
|
||
Comment 2•11 years ago
|
||
Comment on attachment 804191 [details] [diff] [review]
Rename FooReturnValue unions to OwningFoo, because we use them for more than just return values.
Review of attachment 804191 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/bindings/Codegen.py
@@ +813,1 @@
>
What do you think of naming this ownsMembers instead? I think it's a little clearer, but I don't care much either way.
Attachment #804191 -
Flags: review?(dzbarsky) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Which "this"? I think you have Splinter quoting fail...
Flags: needinfo?(dzbarsky)
|
|
||
Comment 4•11 years ago
|
||
(In reply to Boris Zbarsky [:bz] from comment #3)
> Which "this"? I think you have Splinter quoting fail...
Hmm, weird. FWIW you can click on review to see my comments in the splinter view. I was talking about
owningUnionStructs[name] = CGUnionStruct(t, providers[0],
isOwning=True)
Flags: needinfo?(dzbarsky)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Ah. Yes, makes sense. Will do.
|
|
Assignee | |
Comment 6•11 years ago
|
||
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla27
|
||
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•