Closed
Bug 917689
Opened 11 years ago
Closed 11 years ago
LockScreen won't slide on B2G desktop and Firefox nightly
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)
Tracking
(b2g-v1.2 fixed, b2g-v1.3 fixed)
RESOLVED
FIXED
People
(Reporter: gweng, Assigned: gweng)
Details
Attachments
(1 file)
|
(deleted),
text/html
|
timdream
:
review+
timdream
:
approval-gaia-v1.2+
|
Details |
This bug seems only affecting the slider on MacOSX. I've no idea why it won't happen on Ubuntu desktop. However, I've made a patch to fix it.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → gweng
|
|
Assignee | |
Comment 1•11 years ago
|
||
The flag will be set at wrong time.
Attachment #806491 -
Flags: review?(timdream)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 806491 [details]
Patch
This is probably due to some minor difference on touch interface between OSes.
Attachment #806491 -
Flags: review?(timdream) → review+
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•11 years ago
|
blocking-b2g: --- → koi?
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
||
Comment 4•11 years ago
|
||
Not blocking product release for B2G desktop Firefox nightly issues.
blocking-b2g: koi? → -
|
|
Assignee | |
Updated•11 years ago
|
blocking-b2g: - → koi?
|
|
||
Updated•11 years ago
|
Attachment #806491 -
Flags: approval-gaia-v1.2+
|
|
||
Updated•11 years ago
|
blocking-b2g: koi? → ---
|
||
Comment 5•11 years ago
|
||
I was not able to uplift this bug to v1.2. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with:
git checkout v1.2
git cherry-pick -x -m1 8edfa18285f8c36fd6ed783c4e6db81c4c6e9dd0
<RESOLVE MERGE CONFLICTS>
git commit
Flags: needinfo?(gweng)
|
|
Assignee | |
Comment 6•11 years ago
|
||
Hello John,
I've leave the related ni in Bug 919854. The conflicts problem should be solved now.
Flags: needinfo?(gweng)
|
|
||
Comment 7•11 years ago
|
||
Greg, please make sure that you set flags for branch landings when you do them
v1.2: https://github.com/snowmantw/gaia/commit/963b7420996ce9150b0eb04ea5db36823e9c0550
status-b2g-v1.2:
--- → fixed
|
|
||
Comment 8•11 years ago
|
||
Uplifted 8edfa18285f8c36fd6ed783c4e6db81c4c6e9dd0 to:
v1.3 already had this commit
status-b2g-v1.3:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•