Closed
Bug 919854
Opened 11 years ago
Closed 11 years ago
[LockScreen] The icon effects isn't obvious enough
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)
Tracking
(blocking-b2g:koi+, b2g-v1.2 verified)
People
(Reporter: gweng, Assigned: gweng)
Details
Attachments
(3 files)
It's in spec that the icons should be dark until the user touch on the handle, but current the effects isn't obvious enough. I will try to adjust the opacity value and take two screenshot for comparison.
Assignee | ||
Comment 1•11 years ago
|
||
I've create two videos to demo the difference between 50% and 75% darken icons.
I think 50% is better, but it may be too dark.
Assignee | ||
Comment 2•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → gweng
Assignee | ||
Comment 3•11 years ago
|
||
I need information from UX to decide how dark the icons should be.
Flags: needinfo?(padamczyk)
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to Greg Weng [:snowmantw] from comment #3)
> I need information from UX to decide how dark the icons should be.
I've discussed this offline with Rob and Patrick, and they feel 75% is better.
Flags: needinfo?(padamczyk)
Assignee | ||
Comment 5•11 years ago
|
||
Adjust the opacity as 75%.
Attachment #810895 -
Flags: review?(timdream)
Comment 6•11 years ago
|
||
Comment on attachment 810895 [details]
Patch
CSS change only, but make sure tests passes.
Attachment #810895 -
Flags: review?(timdream) → review+
Assignee | ||
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
blocking-b2g: --- → koi?
Updated•11 years ago
|
blocking-b2g: koi? → koi+
Comment 8•11 years ago
|
||
I was not able to uplift this bug to v1.2. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with:
git checkout v1.2
git cherry-pick -x -m1 026884e5b5b070dfb2532e7cf1984973874f0e74
<RESOLVE MERGE CONFLICTS>
git commit
Flags: needinfo?(gweng)
Assignee | ||
Comment 9•11 years ago
|
||
Hello John,
I'd rearranged these related commits and sent a pull request to merge them to the v1.2 branch,
they now should work well. The pull request is at
https://github.com/mozilla-b2g/gaia/pull/12786
And the bugs are
Bug 921334, Bug 921335, Bug 919858, Bug 919850, Bug 921360, Bug 919854, Bug 917689, Bug 903924
They had been described at Bug 921334.
Flags: needinfo?(gweng)
Comment 10•11 years ago
|
||
Greg, please make sure that you set flags for branch landings when you do them
v1.2: https://github.com/snowmantw/gaia/commit/c78ba798b990f833df845e931b94e4558d13f43f
status-b2g-v1.2:
--- → fixed
Comment 11•11 years ago
|
||
Verified fixed on Buri v1.2 comRIL.
Environmental Variables:
BuildID: 20131105004003
Gaia: be4ea00a50236b10eb0a03232a28ffd0048e0cb8
Gecko: 3ba912717904
Version: 26.0
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•