-> blizzard@mozilla.org

Chris, can you review this patch for me?

A couple of minor things: You might want to check for $PKGCONFIG as well as pkg-config so that we can pass PKGCONFIG to configure for cross-compiling and such rather than requiring path changes. Also, you should probably use $PKGCONFIG_PATH (should be PKGCONFIG) when you call pkg-config later in the test. Can you change the error message: AC_MSG_ERROR(Toolkit must be Xlib, GTK, GTK2, Qt, or Motif.) to use all lowercase for the toolkit names so that people won't be confused when GTK2 doesn't work. Outside of that, r=cls .

This is a patch that includes some of your comments but also includes Havoc's pkg.m4 script. This handles all of the cases, figures out dependencies, etc. It's much cleaner. It will also let you set $PKG_CONFIG to set the path to the pkg-config script.

r=cls on attachment 43363 [details] [diff] [review]

Checked in. Thanks.

a=brendan@mozilla.org on blizzard's followup to check in missing make vars. /be

May God have mercy on us all. The 212 bug spam-o-rama is Now!