Open
Bug 922231
Opened 11 years ago
Updated 2 years ago
SDK_LIBRARY and SHARED_LIBRARY_LIBS should imply LIB_PREFIX/SUFFIX
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
NEW
People
(Reporter: mshal, Unassigned)
References
(Depends on 1 open bug)
Details
Both of these variables have definitions like "$(DEPTH)/toolkit/xre/$(LIB_PREFIX)xulapp_s.$(LIB_SUFFIX)" (in the Makefile world) or "%s%s.%s" % (CONFIG['LIB_PREFIX'], 'xpcomglue_s', CONFIG['LIB_SUFFIX']), (moz.build world). I believe all assignments always have LIB_PREFIX/LIB_SUFFIX attached to all values, so we mind as well pull that out of the leaf files and put it into the mozbuild classes for those variables. These would result in:
SHARED_LIBRARY_LIBS = [
'../parentalcontrols/parentalcontrols_s', # objdir-relative path example
'/accessible/src/xul/accessibility_xul_s', # DEPTH-relative path example
]
SDK_LIBRARY = 'xpcomglue_s'
Note some directories assign values to these variables from configure (things like MOZ_ICU_LIBS), so those would need to be updated as well.
Updated•7 years ago
|
Product: Core → Firefox Build System
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•