Closed
Bug 922540
Opened 11 years ago
Closed 11 years ago
rewrite build/additional-extensions.py in javascript
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yurenju, Assigned: dwi2)
References
Details
Attachments
(1 file)
rewrite it in javascript for using it in firefox extension.
Assignee | ||
Updated•11 years ago
|
Assignee: yurenju.mozilla → tzhuang
Assignee | ||
Comment 1•11 years ago
|
||
WIP commit https://github.com/dwi2/gaia/commit/11c1dc592585049aff8b93d0e57e1d8abdf17889
Assignee | ||
Comment 2•11 years ago
|
||
Hi Yuren, Please kindly help to review this patch, Thanks
Attachment #823715 -
Flags: review?(yurenju.mozilla)
Reporter | ||
Comment 3•11 years ago
|
||
Comment on attachment 823715 [details]
pull request
Hi Tzu-Lin, I left some comments on github, set review flag to me if you have updated pull reqeust, thank you!
Attachment #823715 -
Flags: review?(yurenju.mozilla)
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 823715 [details]
pull request
Hi Yuren,
I have updated pull request. Please help to review it.
I updated pull request with 4 commits. Once r+, I'll squash them into one.
Thanks
Attachment #823715 -
Flags: review?(yurenju.mozilla)
Reporter | ||
Comment 5•11 years ago
|
||
Comment on attachment 823715 [details] pull request r=yurenju if comments on github are addressed, I didn't test it on Windows because bug 936375, please make sure you have tested it on Windows before landed it.
Attachment #823715 -
Flags: review?(yurenju.mozilla) → review+
Reporter | ||
Comment 6•11 years ago
|
||
merged. https://github.com/mozilla-b2g/gaia/commit/19cfcf4a2835734f42171daf7dc3c146f377cf22
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•