Closed
Bug 922550
Opened 11 years ago
Closed 11 years ago
update Unicode support to v6.3
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: smontagu, Assigned: smontagu)
References
()
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
jfkthame
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #795025 +++
We should update the various data tables, etc., that depend on Unicode, now that v6.3 is officially released.
Assignee | ||
Comment 1•11 years ago
|
||
Very little has actually changed in character properties this time. The biggest change is the update to the Unicode Bidi Algorithm, which I filed as bug 922963.
There is a change of general category from Sm to Ps/Pe for four characters: U+2308 - U+230B, LEFT/RIGHT FLOOR/CEILING. This will affect first-letter behaviour, so I've added a reftest for that.
Assignee: nobody → smontagu
Attachment #813016 -
Flags: review?(jfkthame)
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 813016 [details] [diff] [review]
Update Unicode data tables
https://tbpl.mozilla.org/?tree=Try&rev=5f223044c3a2 has reftest failures on OSX 10.7 and Windows. Removing review request for now.
Attachment #813016 -
Flags: review?(jfkthame)
Assignee | ||
Comment 3•11 years ago
|
||
The reftest was failing because a smaller area was getting the "background-color" in a <span> as opposed to :first-letter. I assume that's a bug, but it's not relevant to what we're testing here so I just removed the background-color from the testcase.
Attachment #813016 -
Attachment is obsolete: true
Attachment #813937 -
Flags: review?(jfkthame)
Comment 4•11 years ago
|
||
Comment on attachment 813937 [details] [diff] [review]
Update Unicode data tables with updated reftest
Review of attachment 813937 [details] [diff] [review]:
-----------------------------------------------------------------
This looks fine, but please also file a bug (with a currently-failing testcase) about the issue mentioned in comment #3 -- sounds like an issue we should try to investigate further sometime.
Attachment #813937 -
Flags: review?(jfkthame) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Sorry for the churn, I only just noticed another change in 6.3: the unassigned code points in the Currency Symbols block have been given the Bidi_Class property value ET.
Attachment #813937 -
Attachment is obsolete: true
Attachment #820229 -
Flags: review?(jfkthame)
Comment 6•11 years ago
|
||
Comment on attachment 820229 [details] [diff] [review]
Updated patch
Review of attachment 820229 [details] [diff] [review]:
-----------------------------------------------------------------
Looks fine to me.
::: layout/reftests/bidi/922550-1-ref.html
@@ +16,5 @@
> + <p>$$$$1000000 סרפ!!!</p>
> + <p>₠₠₠₠1000000 סרפ!!!</p>
> + <p>₺₺₺₺1000000 סרפ!!!</p>
> + <p>⃏⃏⃏⃏1000000 סרפ!!!</p>
> + <p>₠₡₢₣₤₥₦₧₨₩₪₫€₭₮₯₰₱₲₳₴₵₶₷₸₹₺₻₼₽₾₿⃀⃁⃂⃃⃄⃅⃆⃇⃈⃉⃊⃋⃌⃍⃎⃏1000000 סרפ!!!</p>
Please wrap this line to a more reasonable width (e.g. using <!-- \n --> to avoid introducing whitespace).
::: layout/reftests/bidi/922550-1.html
@@ +13,5 @@
> + <p>פרס $$$$1000000!!!</p>
> + <p>פרס ₠₠₠₠1000000!!!</p>
> + <p>פרס ₺₺₺₺1000000!!!</p>
> + <p>פרס ⃏⃏⃏⃏1000000!!!</p>
> + <p>פרס ₠₡₢₣₤₥₦₧₨₩₪₫€₭₮₯₰₱₲₳₴₵₶₷₸₹₺₻₼₽₾₿⃀⃁⃂⃃⃄⃅⃆⃇⃈⃉⃊⃋⃌⃍⃎⃏1000000!!!</p>
ditto
Attachment #820229 -
Flags: review?(jfkthame) → review+
Assignee | ||
Comment 7•11 years ago
|
||
Flags: in-testsuite+
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•