Open
Bug 924202
Opened 11 years ago
Updated 2 years ago
Add the separator to combined buttons outside of the #nav-bar
Categories
(Firefox :: Theme, defect)
Tracking
()
NEW
People
(Reporter: Gijs, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Australis:P5])
So in bug 924201 mconley noted that the urlbar-container now has a separator drawn where it shouldn't, because it's being matched by these rules. We'll now explicitly exclude the urlbar-container's back/fwd button, but it made me wonder about this rule:
a) why only #nav-bar? Why not all toolbars?
b) if there's some reason not to generalize, maybe we should instead just restrict it to the buttons in question, or a particular opt-in class. That'll be easier for add-ons, too, and it'll help with stuff like bug 916953.
Mike and I weren't really decided, I think (perhaps in part due to summit-induced ineptness towards making decisions). Jared, got an opinion on this one? :-)
Updated•11 years ago
|
Summary: Figure out #nav-bar specificness of toolbarbutton's separator rule, and/or how we should include/exclude items → Figure out #urlbar-container specificness of toolbarbutton's separator rule, and/or how we should include/exclude items
Updated•11 years ago
|
Summary: Figure out #urlbar-container specificness of toolbarbutton's separator rule, and/or how we should include/exclude items → Figure out #nav-bar specificness of toolbarbutton's separator rule, and/or how we should include/exclude items
Updated•11 years ago
|
Flags: needinfo?(jaws)
Comment 1•11 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #0)
> a) why only #nav-bar? Why not all toolbars?
Because only the #nav-bar has the "Australis"-styled buttons so far. We'll need to fix the bugs blocking bug 767319 before we can place the separators elsewhere.
> b) if there's some reason not to generalize, maybe we should instead just
> restrict it to the buttons in question, or a particular opt-in class.
> That'll be easier for add-ons, too, and it'll help with stuff like bug
> 916953.
This was fixed in bug 924933.
Flags: needinfo?(jaws)
Updated•11 years ago
|
Summary: Figure out #nav-bar specificness of toolbarbutton's separator rule, and/or how we should include/exclude items → Add the separator to combined buttons outside of the #nav-bar
Updated•11 years ago
|
Blocks: australis-buttons
Updated•11 years ago
|
Whiteboard: [Australis:P5][Australis:M?] → [Australis:P5]
Updated•11 years ago
|
Flags: firefox-backlog?
Updated•11 years ago
|
Flags: firefox-backlog? → firefox-backlog+
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•