Closed Bug 767319 (australis-buttons) Opened 12 years ago Closed 8 years ago

Use Australis button styling in all UI areas

Categories

(Firefox :: Theme, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: u428464, Unassigned)

References

(Depends on 1 open bug, Blocks 2 open bugs, )

Details

(Keywords: meta, Whiteboard: [Australis:P4+])

For more UI consistency all buttons should use the Australis button styling as seen on the nav bar. Bugs for bookmarks bar and small icons mode have already been filed, but there are other places where the old styling is still used (library, error console, etc.)
Depends on: 734326, 736179, 747140
Depends on: australis-navbar
what about panorama?
Keywords: meta
Panorama is going away (will become an add-on). I've made a list of the areas that could benefit of the Australis styling : -Bookmarks toolbar items -Findbar (the buttons are to be changed in bug 776708 ) -Menu bar -Library -All in-content/panels buttons (complete buttons restyling) -Print Preview -Page info -Error console (may be unnecessary since AFAIR it's going away) -No more small icons mode (it's going away)
Summary: [meta]Use Australis button styling in all UI areas → Use Australis button styling in all UI areas
Depends on: 856665
Status: UNCONFIRMED → NEW
Ever confirmed: true
No longer depends on: australis-navbar
Depends on: 859776
Blocks: 869104
Blocks: australis
No longer blocks: 869104
Whiteboard: [Australis:M7]
Alias: australis-buttons
I can handle this. What are the exact areas that need the updated styles? I know small icons mode is going away, is the library window?
(In reply to Brandon Cheng from comment #3) > I can handle this. What are the exact areas that need the updated styles? I > know small icons mode is going away, is the library window? I would say bookmarks bar, Library, findbar, addons bar , menu bar , error console and print preview, but UX feedback seems needed here.
(In reply to Guillaume C. [:ge3k0s] from comment #4) > (In reply to Brandon Cheng from comment #3) > > I can handle this. What are the exact areas that need the updated styles? I > > know small icons mode is going away, is the library window? > > I would say bookmarks bar, Library, findbar, addons bar , menu bar , error > console and print preview, but UX feedback seems needed here. This is a meta bug, and it's probably best to look at the dependent bugs without owners, to start with.
(In reply to :Gijs Kruitbosch from comment #5) > (In reply to Guillaume C. [:ge3k0s] from comment #4) > > (In reply to Brandon Cheng from comment #3) > > > I can handle this. What are the exact areas that need the updated styles? I > > > know small icons mode is going away, is the library window? > > > > I would say bookmarks bar, Library, findbar, addons bar , menu bar , error > > console and print preview, but UX feedback seems needed here. > > This is a meta bug, and it's probably best to look at the dependent bugs > without owners, to start with. For now I've only filed a bug for the bookmarks bar, but I was wondering if the general styling could not directly be changed everywhere for the Australis one.
(In reply to Guillaume C. [:ge3k0s] from comment #6) > (In reply to :Gijs Kruitbosch from comment #5) > > (In reply to Guillaume C. [:ge3k0s] from comment #4) > > > (In reply to Brandon Cheng from comment #3) > > > > I can handle this. What are the exact areas that need the updated styles? I > > > > know small icons mode is going away, is the library window? > > > > > > I would say bookmarks bar, Library, findbar, addons bar , menu bar , error > > > console and print preview, but UX feedback seems needed here. > > > > This is a meta bug, and it's probably best to look at the dependent bugs > > without owners, to start with. > > For now I've only filed a bug for the bookmarks bar, but I was wondering if > the general styling could not directly be changed everywhere for the > Australis one. I'm not sure if we want to change the toolkit looks. My understanding is that this is a browser makeover, and we probably don't want to break other consumers of toolkit CSS. This would mean that the amount of shared styling code is limited. This could be changed by sharing more code browser-side, of course, if that was a sensible thing to do. And that might well be so, but I'd think it probably makes sense to do things separately at first and then unify/de-dupe what is unifiable/de-dupable. As it is, there's a separate bug for the bookmarks bar, from what I understand the plan is for the library to go in-content, which means it'll have to be restyled completely anyway and might not be the best place to invest effort right now. The findbar has its own bug elsewhere with Mike de Boer working on it, the future of the add-ons bar is as-yet uncertain. I'm not sure how clearly the Australis design would apply to things in the menubar (where things obviously have a different height etc.) and haven't seen a design for it, and the error console no longer has a UI access point by default (takes twiddling devtools.chrome.enabled in about:config, AFAIK). So all in all I'm inclined to recommend just starting with the bookmarks bar, and meanwhile ask for clarification / designs from UX. Stephen, can you correct me, please? I'm sure some of the above is at least a little bit inaccurate, if only for being incomplete. :-)
Flags: needinfo?(shorlander)
(In reply to :Gijs Kruitbosch from comment #7) > I'm not sure how clearly the Australis design would apply to things in the > menubar (where things obviously have a different height etc.) and haven't > seen a design for it The only problem is inconsistency when widgets are put there. Their styling isn't consistent with the one they have in other areas.
Depends on: 875479
Depends on: 868622
I'm going to try to drive this home for M7.
Assignee: nobody → mconley
We should get consistent styling on all of Firefox's surfaces. Includes: - Bookmarks bar - Additional toolbars created by add-ons - Library window Leaving out the menu bar for now, since we should still probably special case that.
Flags: needinfo?(shorlander)
Removing the items from M7 that do not block landing on m-c.
Whiteboard: [Australis:M7] → [Australis:M?]
This bug is kind of vague and meandering. Is there specific work to do here, or is everything covered by other bugs? Maybe we should just close this one?
Flags: needinfo?(mconley)
It's a meta bug about the new borderless button styling. I think it's fine.
Flags: needinfo?(mconley)
According to Stephen Horlander's answer bugs still need to be filed about Library buttons and add-ons toolbars.
Whiteboard: [Australis:M?]
Depends on: 891258
Whiteboard: [Australis:P5]
Whiteboard: [Australis:P5] → [Australis:P3]
Depends on: 940705
No longer depends on: 940705
Whiteboard: [Australis:P3] → [Australis:P4]
Blocks: 632207
Depends on: 953154
This is a metabug.
Assignee: mconley → nobody
Depends on: 971034
Depends on: 909349
Whiteboard: [Australis:P4] → [Australis:P4+]
Depends on: 980370
Depends on: 980374
Depends on: 982721
Depends on: 984013
Depends on: 984188
Depends on: 990387
Blocks: 990533
No longer blocks: 990533
Depends on: 990533
No longer depends on: 992687
Could this be nominated for the backlog ?
Flags: firefox-backlog?
(In reply to Guillaume C. [:ge3k0s] from comment #17) > Could this be nominated for the backlog ? This is effectively a meta bug, I don't think it makes sense to have that in the backlog. We should have concrete dependencies that can actually be worked on in the backlog instead.
Flags: firefox-backlog?
No longer depends on: 868622
Blocks: fx-qx
No longer blocks: fx-qx
Depends on: 1289147
This will be probably be changed again as a part of Project Photon so closing it now.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.