KTucker [:KTucker][Inactive 3/4/2016] Reporter
	Description • 11 years ago

Description:
Video thumbnails previews are not showing in MMS when attaching a video or receiving a video. A generic video thumbnail is shown.

Repro Steps:
1)  Updated Buri to Build ID: 20131008004009
2)  Tap on the "Messaging" icon.
3)  Tap on the "Compose New Message" icon.
4)  Tap on the "Paperclip" and attach a video to the message.

Actual:
The thumbnail is a generic video icon and instead of a preview thumbnail like a picture.

Expected:
The thumbnail should show a screenshot preview of the video. 

Environmental Variables
Device: Buri v 1.1.0 Mozilla RIL
Build ID: 20131008004009
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/decf58f0d596
Gaia: 313599c293f596519604070fa378ffc89e61e98f
Platform Version: 26.0a2
RIL Version: 01.02.00.019.056 

Notes:
Repro frequency: 100%
See attached: screenshot

	KTucker [:KTucker][Inactive 3/4/2016] Reporter
	Comment 1 • 11 years ago

This issue occurs on Leo v1.1.1 Mozilla Rill

Environmental Variables
Device: Leo v 1.1.1.0 Mozilla COM RIL
Build ID: 20131001041206
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/c630289d6388
Gaia: 02b975e6ce12922928c74276ac7d19432a03f126
Platform Version: 18.1
RIL Version: 01.01.00.019.240 

Video thumbnails in MMS are generic.

	Julien Wajsberg [:julienw]
	Comment 2 • 11 years ago

Yep, we don't display a video thumbnail, that's expected.

Could be a feature request for later, what do you think Wilfried and Joe ?

	Joe Cheng [:jcheng] (please needinfo)
	Comment 3 • 11 years ago

1.3? into feature triage discussion

	Joe Cheng [:jcheng] (please needinfo)
	Comment 5 • 11 years ago

triage: minus and add to backlog

	Gonzalo Andreani
	Comment 6 • 11 years ago

I'd like to help with this bug.

My plan is to copy the logic used in the gaia video app to generate the video thumbnail. There is an API for generating thumbnails in the making (see bug #873959). I can implement the functionality first, close this bug, and then create a new bug that asks to use the new API.

	Julien Wajsberg [:julienw]
	Comment 7 • 11 years ago

Please do!

The relevant code probably lives in compose.js or attachment.js. Also, instead of copy the logic, it's probably better to make it a small library in /shared/js (if it's not there already).

Please ask if you need anymore information, either here or on IRC!

Thanks a lot!

	Gonzalo Andreani
	Comment 8 • 11 years ago

Julien,

I have a been trying to work on this for about a week. I cloned the B2G repo and created an emulator. Everytime I change the code in the GAIA project and rebuild the emulator, the changes are not reflected. Could you help?

	Julien Wajsberg [:julienw]
	Comment 9 • 11 years ago

You don't need to rebuild the emulator to change the code. The emulator is just like a phone: you use "adb" to push changes to the emulator.

To do this, you just need to run the following shell command from the "gaia" directory while the emulator is running:

  APP=sms make install-gaia

This should flash the current version of the SMS/MMS app to the emulator.


Hope this helps

	Julien Wajsberg [:julienw]
	Comment 10 • 11 years ago

Note that you can also probably works directly in Firefox.

Here is how you can do this:

* create a suitable profile:

  PROFILE_FOLDER=profile-sms DEBUG=1 DESKTOP=0 make

* run firefox nightly with this profile:

  /path/to/firefox --no-remote -profile ./profile-sms http://sms.gaiamobile.org:8080

* toggle the "responsive mode" (Ctrl + Shift + M)

Then you can use the app in a limited way; the thread "052780" contains some MMS with a video.

	Julien Wajsberg [:julienw]
	Comment 11 • 11 years ago

The good thing with the way in comment 10 is that you can just hit "reload" in Firefox to see your changes.

	Gonzalo Andreani
	Comment 12 • 11 years ago

I have tried using both firefox and the simulator but neither allows me to put a video on the device. 

I have tried to place a video in my "Pictures" and "Video" folder. The photos are detected but the videos are not. I have also tried to download the videos from the browser on the simulator, but it always throws an error. 

Do you have any idea why this happens?

	Julien Wajsberg [:julienw]
	Comment 13 • 11 years ago

Have you tried the steps in comment 10? The thread "05280" has a MMS with a video, this should be good enough for a start?

	Gonzalo Andreani
	Comment 14 • 11 years ago

That's awesome! It works great. So much simpler than what I have been doing. I should have asked for help sooner

	Gonzalo Andreani
	Comment 15 • 11 years ago

I have a fix ready. I basically copied the code from the video app. I can't see a clear way to extract the thumbnail functionality because it's tightly coupled with the code that extracts and stores the video's metadata into MediaDB. I'm not sure how to separate it. 

Here's my fix if you want to take a look at it...

https://github.com/NakedFerret/gaia/commit/35dca235d4df030c456996d37665c4251a592494

	Julien Wajsberg [:julienw]
	Comment 16 • 11 years ago

I added comments ot your commit.

Don't hesitate to ask if something is not clear enough.


Basically, this looks nice, except I wonder if we should not store the thumbnails instead of generating them each time. Bug 876467 is especially related if you want to have a look, but it's maybe difficult for a first-time contributor.
Gecko can be smart about images (like decoding them directly in a smaller size) and it can't for videos.

Some other general notes:
* you should really create a separate branch to do your work. "master" should only contain the master code from mozilla, regularly fetched and merged (I even use "reset --hard" to be sure it's always correct, but it can be scary ;) )
* then, please create a pull request out of your branch, this will make it easier to see the history of comments

Thanks !

	Julien Wajsberg [:julienw]
	Comment 17 • 11 years ago

Oleg, do you mind following this bug as a mentored bug (instead of me ;) ) ? Also, Bug 876467 could probably be a nice addition to your thoughts about an in-app database.

	Oleg Zasypkin [:azasypkin]
	Comment 18 • 11 years ago

(In reply to Julien Wajsberg [:julienw] from comment #17)
> Oleg, do you mind following this bug as a mentored bug (instead of me ;) ) ?
> Also, Bug 876467 could probably be a nice addition to your thoughts about an
> in-app database.

Sure, I'm happy to help with that!

Gonzalo, please ping me here or on IRC if you have any questions.

Thanks!

	Julien Wajsberg [:julienw]
	Comment 20 • 10 years ago

Brett had a good idea in bug 1047479: if we can get the thumbnail directly from the video application (when attaching and when viewing) it could be nicer than decoding ourself.

	Gonzalo Andreani
	Comment 21 • 10 years ago

Yes, I'll try to see if we can do that. Hopefully I'll have sometime this week to finish this fix

	Julien Wajsberg [:julienw]
	Comment 22 • 10 years ago

I gave more thought: if we get the thumbnail from the Video app, then we need to store it locally. But we don't really have a DB in the SMS app yet (we plan to have one before the end of this year). So we're not in a very good position right now...

Maybe you can try to use asyncStorage to store the video thumbnail (using a "message-<id>" key)?

	Julien Wajsberg [:julienw]
	Comment 24 • 9 years ago

Reseting the assignee.

Gonzalo, if you still want to work on this, please do ! :)

	Julien Wajsberg [:julienw]
	Comment 25 • 9 years ago

Marking as a mentored bug. Not sure what the right approach is, it could be better to wait for the DB in Gaia bug.

	Julien Wajsberg [:julienw]
	Comment 26 • 8 years ago

Mass closing of Gaia::SMS bugs. End of an era :(

	Julien Wajsberg [:julienw]
	Comment 27 • 8 years ago

Mass closing of Gaia::SMS bugs. End of an era :(