Closed Bug 925720 Opened 11 years ago Closed 11 years ago

Enable periodic pgo builds on birch

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: glandium, Assigned: mozilla)

References

Details

Attachments

(1 file)

This would probably look like this: diff -r 4df5e64ecf66 mozilla/project_branches.py --- a/mozilla/project_branches.py Thu Oct 10 17:13:19 2013 -0700 +++ b/mozilla/project_branches.py Fri Oct 11 21:55:11 2013 +0900 @@ -187,7 +187,9 @@ }, }, }, - 'birch': {}, + 'birch': { + 'pgo_strategy': 'periodic', + }, 'cedar': { 'mozharness_tag': 'default', 'enable_talos': True,
Found in triage.
Component: Other → General Automation
QA Contact: joduinn → catlee
Ah, it would be *very* useful to have nightly jobs too, including l10n repacks.
JB b2g builds are also missing, as well as b2g tests.
(In reply to Mike Hommey [:glandium] from comment #2) > Ah, it would be *very* useful to have nightly jobs too, including l10n > repacks. Adding l10n repacks would be really, really expensive. It's not really practical, sorry :(.
They are prioritized as the lowest of the low, just like everything else on twigs, though, aren't they? I noticed that the utterly pointless ones on Cedar, which does things like run four nightlies that nobody looks at on a single push, were pending for almost two hours today before they finally ran.
(In reply to Phil Ringnalda (:philor) from comment #5) > They are prioritized as the lowest of the low, just like everything else on > twigs, though, aren't they? I noticed that the utterly pointless ones on > Cedar, which does things like run four nightlies that nobody looks at on a > single push, were pending for almost two hours today before they finally ran. That's true, but they still block jobs that came in after the slave picked up a repack from starting. If we could reduce the # of locales we do it wouldn't be so bad. Might be able to do that by changing the all-locales file (like https://github.com/mozilla/build-buildbot-configs/blob/master/mozilla/l10n/all-locales.mozilla-central) come to think of it. We might have other bumps in doing l10n on twigs - I don't think we've done it before.
Attached patch birch.diff (deleted) — Splinter Review
I think this addresses every concern in this bug... l10n is nightly-only, which should reduce the load. :glandium, could you trim http://hg.mozilla.org/projects/birch/file/7e40af5a70ee/browser/locales/all-locales and http://hg.mozilla.org/projects/birch/file/7e40af5a70ee/mobile/android/locales/all-locales to a subset you care about, to further reduce load? I think Android chunks into 5 so we may need at least 5 locales, not sure.
Attachment #8333863 - Flags: review?(bhearsum)
Comment on attachment 8333863 [details] [diff] [review] birch.diff Review of attachment 8333863 [details] [diff] [review]: ----------------------------------------------------------------- I really think it's a bad idea to run l10n nightlies on twigs. Not only does it waste a ton of machine time, it can create confusion for localizers. If we must do this can we use a custom all-locales file that only repacks x-testing?
(In reply to Ben Hearsum [:bhearsum] from comment #8) > Comment on attachment 8333863 [details] [diff] [review] > birch.diff > > Review of attachment 8333863 [details] [diff] [review]: > ----------------------------------------------------------------- > > I really think it's a bad idea to run l10n nightlies on twigs. Not only does > it waste a ton of machine time, it can create confusion for localizers. If > we must do this can we use a custom all-locales file that only repacks > x-testing? I think it's necessary, especially since :glandium et al are making build system changes that regularly break l10n.
Assignee: nobody → aki
Attachment #8333863 - Flags: review?(bhearsum) → review?(jhopkins)
(Ben asked me to change reviewers in IRC.)
How about not running them periodically, but having them triggerable from self-serve?
Attachment #8333863 - Flags: review?(jhopkins) → review+
(In reply to Mike Hommey [:glandium] from comment #11) > How about not running them periodically, but having them triggerable from > self-serve? Possibly? This is the fastest fix though, since the patch is here+reviewed. We can back parts of this patch out when bug 793989 lands. (Are you talking about all nightlies/pgo, or just the l10n with this statement?)
(In reply to Aki Sasaki [:aki] from comment #13) > (In reply to Mike Hommey [:glandium] from comment #11) > (Are you talking about all nightlies/pgo, or just the l10n with this > statement?) All of the above.
Ok. Yeah, bug 793989.
Can we add Nightlies and l10n builds for Android to this list, if it's not already there? This could close Bug 941290.
(In reply to Nick Alexander :nalexander PTO until Dec 7th from comment #16) > Can we add Nightlies and l10n builds for Android to this list, if it's not > already there? This could close Bug 941290. Looks like Android nightly birch l10n is already on the list, once we reconfig.
something[s] here made it to production
I'm going to be optimistic and call this done, but not optimistic enough to resolve the bug til we see it.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: