Closed
Bug 927766
Opened 11 years ago
Closed 11 years ago
Button "Join hidden network" is not localized during FTE
Categories
(Firefox OS Graveyard :: Gaia::First Time Experience, defect)
Firefox OS Graveyard
Gaia::First Time Experience
Tracking
(blocking-b2g:koi+, b2g-v1.2 verified)
People
(Reporter: flod, Assigned: flod)
References
Details
(Keywords: l12y, late-l10n)
Attachments
(1 file)
Using Geeksphone with 1.2, button is displayed in English. Button has an id but not a data-l10n-id https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/ftu/index.html#L188
Assignee | ||
Comment 1•11 years ago
|
||
I'm checking the original PR and there are other strings not marked with data-l10n-id https://github.com/mozilla-b2g/gaia/pull/9828/files <option>WEP</option> <option selected>WPA-PSK</option> <option>WPA-EAP</option> Since we have similar strings in Settings, not sure why these are hard-coded https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/locales/settings.en-US.properties#L301
Comment 2•11 years ago
|
||
Adding l12y keyword and requesting koi
blocking-b2g: --- → koi?
Keywords: l12y
Assignee | ||
Comment 3•11 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•11 years ago
|
Attachment #819097 -
Flags: review?(fernando.campo)
Comment 4•11 years ago
|
||
Comment on attachment 819097 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12941 short and clear. Thanks Francesco. wonder if we need also review from l10n team?
Attachment #819097 -
Flags: review?(fer.campo.garcia+bugzilla) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Technically I'm part of the l10n team (Pike is already CCed anyway) ;-) Maybe adding WEP, WPA, etc. is a bit overkill, but I think it could be needed for locales with non latin script. P.S. Someone needs to merge this PR for me, since I have no commit rights over there.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → francesco.lodolo
Comment 6•11 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #5) > Technically I'm part of the l10n team (Pike is already CCed anyway) ;-) Oh, didn't know that, I only knew pike and stas :) > Maybe adding WEP, WPA, etc. is a bit overkill, but I think it could be > needed for locales with non latin script. Agree > P.S. Someone needs to merge this PR for me, since I have no commit rights > over there. merged on master https://github.com/mozilla-b2g/gaia/commit/114a899d6878f92170f471281a5d1de9bac55c48
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
blocking-b2g: koi? → koi+
Comment 7•11 years ago
|
||
Uplifted 114a899d6878f92170f471281a5d1de9bac55c48 to: v1.2: 147207b1125c31e9dd63daae5365b2488ab70e45
status-b2g-v1.2:
--- → fixed
Comment 8•11 years ago
|
||
Verified on 1.2 build. Environmental Variables: BuildID: 20131111004004 Gaia: 670b2c8329bca6f142939185be71274166d82bb8 Gecko: 1ac147e4e2f0 Version: 26.0
You need to log in
before you can comment on or make changes to this bug.
Description
•