The Wi-Fi panel lacks an option to add a hidden Wi-Fi network.

Triage: BB-, tracking-b2g18+ this could be a feature request for FTE

Patch for the Bug #866484 have landed earlier today so its now possible to apply my hidden wifi patch for #824366.

When Bug #802137 will land we will be able to validate the input without duplication the code.

First of all, thanks for the work Michal, whole new screen looks cool, but I have some comments on it before approving it. - We should get some feedback from UX about the looks and position for the 'Join hidden network button', as right now it doesn't follow the FTU style completely. I'm adding Victoria as designer for FTU. - The style for the add hidden network screen looks good, but I miss the 'show password' option which is already implemented on FTU and Settings - You already spoke about the input validation on comment 4, we should disable the OK button by default. - We need also some feedback about the expected behaviour when we try to join a hidden network. My understanding is that it should be a little different from settings, as in there we access the option from manage networks, which is a panel we don't have in here. Should we add it to the list of detected networks? Should we try to connect to it? What if we are unable to connect? Show it anyway or hide it? Also, as it add some new strings, I'm adding the late-l10n keywords.

Adding a screenshot of the style for the button for UX review

Any news on this? I'm waiting for a UX feedback for almost 10 days now.

Latest news I have is that this bug being a non-blocker and due to loadwork for UX, it's down on the list of importance. I'll re-ping some UX in case any have some free time to give feedback about the button.

Hi, to triagers: I filed this bug back in december, when I found that I really _needed_ thiswhen I dogfooded the phone. This was not made a blocker at the time, for a good reason (we were rushing to a 1.0 release.. which incidently we still don't have), I'd really like to have it block now, so that we can do it. It's not a big work to do, Fernando already had some UX proposition that needs some stamp from the UX people, the code to do this will be fairly small. Please block on this as this will give some good value to our product, for a small price of work.

Still not a blocker for v1.1 - no new feature scope can be taken at this time.

Definitely want to improve the look of the button seen in the comment 6 screenshot. Eric or Patryk, can you comment here in place of Victoria?

Can we adjust the layout so the new button for hidden wifi aligns with the bottom 2 buttons, there should be a left and right margin of 15px. See above screenshot.

Great Patryk, thanks.

Button UX fixed according to the screenshot, input validation added using helper from Bug #802137, ready for review.

wrote few comments on github, I only made a quick review while on the train and tested on nightly, but will check again later with phone. Looks good :)

Comment on attachment 750816 [details] patch Working perfect, thanks Michal :) Just adress the small comments, squash commits, and we're good to go

Thanks Fernando! Merged: https://github.com/mozilla-b2g/gaia/commit/e4a5c305c56c9b7c55c06e586c87e65dc104d556

This bug was partially uplifted. Uplifted e4a5c305c56c9b7c55c06e586c87e65dc104d556 to: v1.2 already had this commit Commit e4a5c305c56c9b7c55c06e586c87e65dc104d556 didn't uplift to branch v1-train

bajaj, did you slip the approval to leo+? This is a late-l10n bug, plus akeybl minused it in comment 10.

(In reply to Axel Hecht [:Pike] from comment #20) > bajaj, did you slip the approval to leo+? > > This is a late-l10n bug, plus akeybl minused it in comment 10. Indeed, sorry my bad ! was suppose to be koi+ .