Julien Wajsberg [:julienw] Reporter
	Description • 12 years ago

The Wi-Fi panel lacks an option to add a hidden Wi-Fi network.

	Joe Cheng [:jcheng] (please needinfo)
	Comment 1 • 12 years ago

Triage: BB-, tracking-b2g18+
this could be a feature request for FTE

	Michał Budzyński (:michalbe) Assignee
	Comment 3 • 11 years ago

Patch for the Bug #866484 have landed earlier today so its now possible to apply my hidden wifi patch for #824366.

	Michał Budzyński (:michalbe) Assignee
	Comment 4 • 11 years ago

When Bug #802137 will land we will be able to validate the input without duplication the code.

	Fernando Campo (:fcampo)
	Comment 5 • 11 years ago

First of all, thanks for the work Michal, whole new screen looks cool, but I have some comments on it before approving it.

- We should get some feedback from UX about the looks and position for the 'Join hidden network button', as right now it doesn't follow the FTU style completely. I'm adding Victoria as designer for FTU.
- The style for the add hidden network screen looks good, but I miss the 'show password' option which is already implemented on FTU and Settings
- You already spoke about the input validation on comment 4, we should disable the OK button by default.
- We need also some feedback about the expected behaviour when we try to join a hidden network. My understanding is that it should be a little different from settings, as in there we access the option from manage networks, which is a panel we don't have in here.
Should we add it to the list of detected networks?
Should we try to connect to it? What if we are unable to connect? Show it anyway or hide it?

Also, as it add some new strings, I'm adding the late-l10n keywords.

	Fernando Campo (:fcampo)
	Comment 6 • 11 years ago

Adding a screenshot of the style for the button for UX review

	Michał Budzyński (:michalbe) Assignee
	Comment 7 • 11 years ago

Any news on this? I'm waiting for a UX feedback for almost 10 days now.

	Fernando Campo (:fcampo)
	Comment 8 • 11 years ago

Latest news I have is that this bug being a non-blocker and due to loadwork for UX, it's down on the list of importance.

I'll re-ping some UX in case any have some free time to give feedback about the button.

	Julien Wajsberg [:julienw] Reporter
	Comment 9 • 11 years ago

Hi, to triagers: I filed this bug back in december, when I found that I really _needed_ thiswhen I dogfooded the phone. This was not made a blocker at the time, for a good reason (we were rushing to a 1.0 release.. which incidently we still don't have), I'd really like to have it block now, so that we can do it.

It's not a big work to do, Fernando already had some UX proposition that needs some stamp from the UX people, the code to do this will be fairly small. Please block on this as this will give some good value to our product, for a small price of work.

	Alex Keybl [:akeybl]
	Comment 10 • 11 years ago

Still not a blocker for v1.1 - no new feature scope can be taken at this time.

	Josh Carpenter [:jcarpenter]
	Comment 11 • 11 years ago

Definitely want to improve the look of the button seen in the comment 6 screenshot. Eric or Patryk, can you comment here in place of Victoria?

	Patryk Adamczyk [:patryk] UX
	Comment 13 • 11 years ago

Can we adjust the layout so the new button for hidden wifi aligns with the bottom 2 buttons, there should be a left and right margin of 15px. See above screenshot.

	Michał Budzyński (:michalbe) Assignee
	Comment 14 • 11 years ago

Great Patryk, thanks.

	Michał Budzyński (:michalbe) Assignee
	Comment 15 • 11 years ago

Button UX fixed according to the screenshot, input validation added using helper from Bug #802137, ready for review.

	Fernando Campo (:fcampo)
	Comment 16 • 11 years ago

wrote few comments on github, I only made a quick review while on the train and tested on nightly, but will check again later with phone. Looks good :)

	Fernando Campo (:fcampo)
	Comment 17 • 11 years ago

Comment on attachment 750816 [details]
patch

Working perfect, thanks Michal :)

Just adress the small comments, squash commits, and we're good to go

	Michał Budzyński (:michalbe) Assignee
	Comment 18 • 11 years ago

Thanks Fernando!

Merged: https://github.com/mozilla-b2g/gaia/commit/e4a5c305c56c9b7c55c06e586c87e65dc104d556

	John Ford [:jhford] CET/CEST Berlin Time
	Comment 19 • 11 years ago

This bug was partially uplifted.

Uplifted e4a5c305c56c9b7c55c06e586c87e65dc104d556 to:
v1.2 already had this commit

Commit e4a5c305c56c9b7c55c06e586c87e65dc104d556 didn't uplift to branch v1-train

	Axel Hecht [:Pike]
	Comment 20 • 11 years ago

bajaj, did you slip the approval to leo+?

This is a late-l10n bug, plus akeybl minused it in comment 10.

	bhavana bajaj [:bajaj]
	Comment 21 • 11 years ago

(In reply to Axel Hecht [:Pike] from comment #20)
> bajaj, did you slip the approval to leo+?
> 
> This is a late-l10n bug, plus akeybl minused it in comment 10.

Indeed, sorry my bad ! was suppose to be koi+ .