Closed
Bug 92933
Opened 24 years ago
Closed 23 years ago
Chatzilla doesn't select tab correctly.
Categories
(Other Applications :: ChatZilla, defect)
Other Applications
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: neil, Assigned: rginda)
References
()
Details
Attachments
(1 file)
|
(deleted),
patch
|
rginda
:
review+
|
Details | Diff | Splinter Review |
function setCurrentObject in static.js
1102: tb.setAttribute ("selected", "false");
1128: tb.setAttribute ("selected", "true");
These should say tb.selected = false; or tb.selected = true; so that the
beforeselected and afterselected attributes get updated correctly.
|
Assignee | |
Comment 1•24 years ago
|
||
beforeselected and afterselected? What are these? Why does tb.selected fix the
problem?
|
Reporter | |
Comment 2•24 years ago
|
||
tb.selected calls the XBL property code which sets attributes properly.
|
|
Assignee | |
Comment 3•23 years ago
|
||
hyatt, what's the deal here? Is this a bug in XBL?
|
||
Comment 4•23 years ago
|
||
What's the conclusion on this? Does it make a difference?
OS: Windows 95 → All
QA Contact: mozilla → samuel
Hardware: PC → All
|
|
||
Comment 5•23 years ago
|
||
ok, hyatt says that they're both the same, but |tab.selected = true;| is preferred.
I'll attach a patch soon.
Status: NEW → ASSIGNED
|
|
||
Comment 6•23 years ago
|
||
|
|
Assignee | |
Comment 7•23 years ago
|
||
Comment on attachment 70244 [details] [diff] [review]
simple change
r=rginda
Attachment #70244 -
Flags: review+
|
|
||
Comment 8•23 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Core → Other Applications
You need to log in
before you can comment on or make changes to this bug.
Description
•