Currently, we use onenabled/ondisalbed DOMEventListener to notify gaia the wifi enable/disable status after issuing settings API to set "wifi.enabled". Instead of that, we would like to propose the setWifiEnable DOM API. It looks more straightforward when trying to turn on/off wifi in gaia. Moreover, we could move the control logic for wifi and wifi hotspot to gaia app. interface nsIDOMWifiManager : nsISupports { nsIDOMDOMRequest setWifiEnable(bool enabled); }

Add |mozWifiManager.setWifiEnable()| for turning wifi on/off.

Comment on attachment 829198 [details] [diff] [review] WIP - 0002. API Implementation. Review of attachment 829198 [details] [diff] [review]: ----------------------------------------------------------------- 0. Dimi is going to move nsIWifi.idl to webidl. Maybe we should write this to webidl, too ? 1. Who should handle initial wifi start, gaia or gecko ? 2. Looks like we don't need handleWifiEnabled() function anymore. Maybe you would like to remove it ?

(In reply to Vincent Chang[:vchang] from comment #3) > Comment on attachment 829198 [details] [diff] [review] > WIP - 0002. API Implementation. > > Review of attachment 829198 [details] [diff] [review]: > ----------------------------------------------------------------- > > 0. Dimi is going to move nsIWifi.idl to webidl. Maybe we should write this > to webidl, too ? If so, I think we might have to freeze API/interface change for Dimi to work on the transformation. Just set it to block until it's become webidl. > 1. Who should handle initial wifi start, gaia or gecko ? > 2. Looks like we don't need handleWifiEnabled() function anymore. Maybe you > would like to remove it ? As an API, the initialization is better handled by gaia. But in case gaia doesn't have such capability, handleWifiEnabled is preserved for now in case we need to handle wifi initialization in gecko.

Change API name.

1. Change API naming. 2. Use queue on wifi enable/disable command.

Comment on attachment 8356485 [details] [diff] [review] 0001. IDL Change. Review of attachment 8356485 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for your patch. But as you may know that we are going to replace the idl to webidl for exposed DOM content. So please based on bug 886110 to develop this.

Comment on attachment 8466046 [details] [diff] [review] 0002. Implement wifi enable API. Review of attachment 8466046 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Thank you.

Add reviewer's name.

Add reviewer's name and TODOs.

Try : https://tbpl.mozilla.org/?tree=Try&rev=2e194b12e98e

Try looks good.

https://hg.mozilla.org/integration/b2g-inbound/rev/22676919a166 https://hg.mozilla.org/integration/b2g-inbound/rev/4353846612d0

https://hg.mozilla.org/mozilla-central/rev/22676919a166 https://hg.mozilla.org/mozilla-central/rev/4353846612d0

Test case will be tracked by Bug 1051660