Jesse Ruderman Reporter
	Description • 11 years ago

###!!! ASSERTION: Scroll frame should be an ancestor of the containing block: 'cbFrame == scrolledFrame || nsLayoutUtils::IsProperAncestorFrame(scrolledFrame, cbFrame)', file layout/generic/StickyScrollContainer.cpp, line 155

	Mats Palmgren (inactive)
	Comment 2 • 11 years ago

Regression window on m-c:  2013-10-25 -- 2013-10-26
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=186e834d87dc&tochange=ef3f5669b53e
contains bug 261037 which seems the most likely candidate given that the test has
<fieldset style="overflow: hidden;">

	Mats Palmgren (inactive)
	Comment 5 • 11 years ago

Comment on attachment 8334330 [details] [diff] [review]
part 1: fix assertions

r=mats, with a couple of nits (fix as you see fit).

>layout/generic/StickyScrollContainer.cpp
>+  StickyScrollContainer* s = static_cast<StickyScrollContainer*>

Renaming 's' to 'oldSSC' would make the code clearer IMO.

>+  for (int32_t i = s->mFrames.Length() - 1; i >= 0; --i) {

In general, I would prefer this pattern:

    auto i = s->mFrames.Length();
    while (i--) {

because:
1. it allows the full range of values that Length() can return
2. it's less to read

	Mats Palmgren (inactive)
	Comment 6 • 11 years ago

Comment on attachment 8334331 [details] [diff] [review]
part 2: support relative and sticky positioning on legends

> layout/reftests/forms/fieldset/relpos-legend-1.html

Please add a rel.pos. inline legend to this test

<fieldset>
  <legend style="display:inline; position:relative; top:20px">Legend</legend>
</fieldset>

	Mats Palmgren (inactive)
	Comment 7 • 11 years ago

... or, if you want to keep it on one line:

    for (auto i = s->mFrames.Length(); i-- ;)

(I'm assuming it's OK to use c++11 auto now.)

	Robert O'Callahan (:roc) (email my personal email if necessary) Assignee
	Comment 8 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/be8c4d516bda
https://hg.mozilla.org/integration/mozilla-inbound/rev/29f004e4fa77

	Carsten Book [:Tomcat]
	Comment 9 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/be8c4d516bda
https://hg.mozilla.org/mozilla-central/rev/29f004e4fa77