Closed
Bug 950418
Opened 11 years ago
Closed 11 years ago
sticky-legend-1.html will be permaorange when 28 merges to beta
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla29
Tracking | Status | |
---|---|---|
firefox26 | --- | unaffected |
firefox27 | --- | unaffected |
firefox28 | --- | fixed |
firefox29 | --- | fixed |
firefox-esr24 | --- | unaffected |
People
(Reporter: philor, Assigned: coyotebush)
References
Details
Attachments
(1 file)
(deleted),
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
It's not glaringly obvious why, like most of them are, but as the reftest orange in https://tbpl.mozilla.org/?tree=Try&rev=9e4d891154f4 (current aurora pushed to try as though it had been merged to beta) shows, sticky-legend-1.html is just waiting for ifdef RELEASE_BUILD to be true so it can become permaorange.
Assignee | ||
Comment 1•11 years ago
|
||
Looks like that reftest doesn't have the sticky pref enabled. Double-checking the fix now.
Assignee | ||
Comment 2•11 years ago
|
||
Yep, that was it. (I didn't manage to enable RELEASE_BUILD locally, but confirmed that it fails without this change if I make the pref always false by default.)
Attachment #8347698 -
Flags: review?(dholbert)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → corey
Reporter | ||
Comment 3•11 years ago
|
||
Just in case you ever need to, the key to RELEASE_BUILD is to take the a1 off the content of config/milestone.txt. 29.0a1 defines NIGHTLY_BUILD, 29.0a2 defines nothing, 29.0 defines RELEASE_BUILD
Assignee | ||
Comment 4•11 years ago
|
||
Thanks. Got that to work, and confirmed that this patch does fix the test with RELEASE_BUILD defined.
Updated•11 years ago
|
Attachment #8347698 -
Flags: review?(dholbert) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/37c7fbeb787a
https://hg.mozilla.org/releases/mozilla-aurora/rev/050d4121ba7b
This test was added in bug 931460 and therefore doesn't exist on beta (unsurprisingly since we'd be perma-failing now otherwise).
tracking-firefox27:
? → ---
Keywords: checkin-needed
Summary: sticky-legend-1.html will be permaorange when 27 merges to beta → sticky-legend-1.html will be permaorange when 28 merges to beta
Reporter | ||
Comment 6•11 years ago
|
||
Counting backward isn't one of my specialties.
Reporter | ||
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•