Yuan Xulei [:yxl] (Leave from May 18) Assignee
	Description • 11 years ago

We have implemented the Keyboard/IME API in gecko. To ensure it works properly and not isn't broken by future patches, we need set up mochitest for it.

	Yuan Xulei [:yxl] (Leave from May 18) Assignee
	Comment 2 • 11 years ago

https://tbpl.mozilla.org/?tree=Try&rev=71625e37c767

	Yuan Xulei [:yxl] (Leave from May 18) Assignee
	Comment 3 • 11 years ago

Comment on attachment 8344592 [details] [diff] [review]
add mochitest v1.patch

Review of attachment 8344592 [details] [diff] [review]:
-----------------------------------------------------------------

Basic tests for mozInputMethod.

	[:fabrice] Fabrice Desré
	Comment 4 • 11 years ago

Comment on attachment 8344592 [details] [diff] [review]
add mochitest v1.patch

Review of attachment 8344592 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for starting that. It's pretty good, but you can simplify somewhat!

::: dom/inputmethod/mochitest/inputmethod_common.js
@@ +26,5 @@
> +    // Backup the old pref values.
> +    prefs.forEach(function(v) {
> +      let name = v[0];
> +      this._boolPrefs.push([name, this._getBoolPref(name)]);
> +    }.bind(this));

You don't need to save old values when using pushPrefEnv

@@ +34,5 @@
> +  addPermissions: function(permissions) {
> +    this._permissions.push(permissions);
> +    permissions.forEach(function(v) {
> +      SpecialPowers.addPermission(v, true, document);
> +    });

Please use pushPermissions() instead of addPermission()

@@ +42,5 @@
> +    this._permissions.forEach(function(v) {
> +      SpecialPowers.removePermission(v, document);
> +    });
> +    SpecialPowers.pushPrefEnv({set: this._boolPrefs}, callback);
> +  },

You don't need this function.

	Yuan Xulei [:yxl] (Leave from May 18) Assignee
	Comment 5 • 11 years ago

The patch fixed the issue in inputmethod_common.js of comment 4.

When running test on Firefox without gaia helper addon, there is a "browser.shell" undefined error in the console, as browser.shell is
not available. The patch also fixed this problem.

	[:fabrice] Fabrice Desré
	Comment 6 • 11 years ago

Comment on attachment 8346055 [details] [diff] [review]
add mochitest v2.patch

Review of attachment 8346055 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

	Yuan Xulei [:yxl] (Leave from May 18) Assignee
	Comment 7 • 11 years ago

@Fabrice, thanks for helping with a load of reviews from me :-)

	Ryan VanderMeulen [:RyanVM]
	Comment 8 • 11 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/d29a46b5d058

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 11 years ago

Disable these tests on Android:
https://hg.mozilla.org/integration/b2g-inbound/rev/ab5feb665350

	Ryan VanderMeulen [:RyanVM]
	Comment 10 • 11 years ago

Backed out for B2G mochitest-4 orange. Please verify that this passes on all affected platforms and include the Android fix from comment 9 before re-landing.
https://hg.mozilla.org/integration/b2g-inbound/rev/e3fe8a0517fe

https://tbpl.mozilla.org/php/getParsedLog.php?id=32098407&tree=B2g-Inbound

	Yuan Xulei [:yxl] (Leave from May 18) Assignee
	Comment 11 • 11 years ago

https://tbpl.mozilla.org/?tree=Try&rev=22560c43d713

The above try server results show that the composition methods of the input method API are broken. The patch marked the corresponding test as TODO and disable it.

	Yuan Xulei [:yxl] (Leave from May 18) Assignee
	Comment 12 • 11 years ago

Let's wait for the try server result before check-in.

https://tbpl.mozilla.org/?tree=Try&rev=2f60924327c1

	Yuan Xulei [:yxl] (Leave from May 18) Assignee
	Comment 13 • 11 years ago

The emulator is green now :-)

	Ryan VanderMeulen [:RyanVM]
	Comment 14 • 11 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/f9b9eae77c66

	Ryan VanderMeulen [:RyanVM]
	Comment 15 • 11 years ago

Backed out for desktop B2G mochitest orange.
https://hg.mozilla.org/integration/b2g-inbound/rev/3ce6af03ee93

https://tbpl.mozilla.org/php/getParsedLog.php?id=32223839&tree=B2g-Inbound

Please give this a full Try run before requesting checkin again.

	Ryan VanderMeulen [:RyanVM]
	Comment 16 • 11 years ago

Same error on desktop Firefox builds as well.

	Yuan Xulei [:yxl] (Leave from May 18) Assignee
	Comment 17 • 11 years ago

@Ryan, thank you. I should have a full try run.

	Yuan Xulei [:yxl] (Leave from May 18) Assignee
	Comment 18 • 11 years ago

https://tbpl.mozilla.org/?tree=Try&rev=7679aa5869a2

	Yuan Xulei [:yxl] (Leave from May 18) Assignee
	Comment 19 • 11 years ago

https://tbpl.mozilla.org/?tree=Try&rev=ab2aceded6e5

	Yuan Xulei [:yxl] (Leave from May 18) Assignee
	Comment 20 • 11 years ago

All input method mochitest tests passed finally.

	Kan-Ru Chen [:kanru] (UTC+9)
	Comment 21 • 11 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/5ba55c9c5ad6

	Carsten Book [:Tomcat]
	Comment 22 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/5ba55c9c5ad6