Closed
Bug 949059
Opened 11 years ago
Closed 11 years ago
"Return value is not an object." thrown when changing input in Contacts
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: julienw, Assigned: xyuan)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
STR: * launch the contacts app * press "+" to add an ew contact * type something in "name" * tap the "Last name" entry * have a look to the logcat => [JavaScript Error: "Return value is not an object."] I debugged this with gdb with :bz and :padenot, and this traces to the "mgmt" property of MozInputMethod. See [1] for the full stack trace. :bz thinks it could be related to the commit [2] (Bug 905573) because the implementation can return "null" in some situations ([3]) whereas the IDL wants an object. I honestly don't know if there is a practical implication. The main issue is that it adds lines to the log, and since there is another issue (to be filed by :bz) we don't see the originating file, and this makes other bugs more difficult to debug. [1] http://pastie.org/8545283 [2] http://hg.mozilla.org/mozilla-central/rev/20b30db87bf4 [3] http://hg.mozilla.org/mozilla-central/rev/20b30db87bf4#l2.206
Reporter | ||
Updated•11 years ago
|
Component: Gaia::Keyboard → DOM
Flags: needinfo?(fabrice)
Product: Firefox OS → Core
Comment 1•11 years ago
|
||
The practical issue is that doing .mgmt will throw in the situations in which the getter returns null. If that's the desired behavior, the getter should instead be throwing, with a more informative error message than just "hey, you promised this wouldn't be null but returned null!". But I expect it's not the desired behavior.
Assignee | ||
Comment 2•11 years ago
|
||
It's an implementation bug. The "mgmt" property of MozInputMethod should never be null.
Attachment #8346061 -
Flags: review?(fabrice)
Comment 3•11 years ago
|
||
Comment on attachment 8346061 [details] [diff] [review] patch v1 Test, please! ;)
Comment 4•11 years ago
|
||
Comment on attachment 8346061 [details] [diff] [review] patch v1 Review of attachment 8346061 [details] [diff] [review]: ----------------------------------------------------------------- r=me but as bz said, we need tests to land that.
Attachment #8346061 -
Flags: review?(fabrice) → review+
Updated•11 years ago
|
Flags: needinfo?(fabrice)
Assignee | ||
Comment 5•11 years ago
|
||
@Fabrice, could you help me to land bug 932145? So that I can write a test based on that bug.
Updated•11 years ago
|
Assignee: nobody → xyuan
Assignee | ||
Comment 7•11 years ago
|
||
Add mochitest. https://tbpl.mozilla.org/?tree=Try&rev=10ce31c5418a
Attachment #8346061 -
Attachment is obsolete: true
Attachment #8350869 -
Flags: review?(fabrice)
Updated•11 years ago
|
Attachment #8350869 -
Attachment is patch: true
Attachment #8350869 -
Flags: review?(fabrice) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/ab453d9db208
Flags: in-testsuite+
Keywords: checkin-needed
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ab453d9db208
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•