see https://github.com/mozilla-b2g/gaia/pull/11866/files#diff-4 Bug 893800 does not create properly a new objectstore for pre-existing database. Requesting koi+ as this is a very serious bug preventing migrations.

(In reply to Julien Wajsberg [:julienw] from comment #0) > see https://github.com/mozilla-b2g/gaia/pull/11866/files#diff-4 > > Bug 893800 does not create properly a new objectstore for pre-existing > database. > > Requesting koi+ as this is a very serious bug preventing migrations. Can you explain a bit more about this could happen? Specifically, I'm looking to understand what STR could trigger this bug, what's the impact, etc.

This happens when you move from v1.1 to v1.2. An easy STR using a geeksphone phone could be: * flash a 1.1 firmware * install some apps, install e.me results on your homescreen, add bookmarks to your homescreen * flash a 1.2 firmware while keeping the userdata I don't know what the impact is as I don't know the code. I know that the objectstore svAppsInstalled won't be created, and that I see errors stating this in logcat. I don't know the impact, probably Carmen or Cristian would know. Flagging them. This _could_ be the bug triggering bug 925461 but I'm not sure.

Please Carmen take a look to this question, thanks

You're right, if the bbdd is already created then the objectStore for single variant is not created. But: - Single variant functionality doesn't apply to actualizations, they only apply for new devices. - An exception is launched (NotFoundError) but the functionality is not affected because of the place where the code is. The single variant datas are loaded at the end of homestate.init when the only task that is pending is loading the single variant app list previously installed and, as I said previously, on the actualizations this list is going to be empty anyway. I'm going to fix it because you are truth, it is ugly, but I don't think it is a blocker because the functionality is not affected.

Is FOTA update impacted? How are 1.1 users impacted when upgraded to 1.2? Is their data intact?

No, FOTA updates will not be impacted. The only effect will be that an error will be logged. The users will not see anything and their data will not be affected.

Sounds like we don't need to block on this then.

The proposed patch resolves the described problem creating a new version of database

Comment on attachment 828581 [details] Patch-v1 I added a comment but I would like to Julien review it because he was who detected the issue and I am in SF very busy and I cannot test on my device. Could you take a look? Thanks a lot Julien

Comment on attachment 828581 [details] Patch-v1 r=me with adding 2 comments I haven't actually tried it on device but this looks good!