The items added in home screen are missing when device updates from v1.2 to v1.3. (for example: website, marketplace installed items, E.me added items) * Build Info (Both Gecko and Gaia) Device Helix Gaia 539a25e1887b902b8b25038c547048e691bd97f6 Gecko http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/e672faf1e6a1 BuildID 20140111004004 Version 26.0 ro.build.version.incremental=eng.wanglei.20131212.005845 ro.build.date=Thu Dec 12 00:58:58 CST 2013 * Reproduce Steps 1. Flash Helix device to v1.2 build from PVT 2. Change update URL to v1.3 (http://update.boot2gecko.org/helix/1.3.0/nightly/update_20140111004005.xml) 3. Add some websites to homescreen 4. Add some apps from marketplace to homescreen 5. Add some apps from E.me to homescreen 6. Perform check now to get the update notifcation 7. Download the update package 8. Install the upgrade package while the package is downloaded. * Actual results: The items added in home screen are missing when device updates from v1.2 to v1.3 * Expected results: The items should be kept.

Cristian, can you take a look here?

I thought that Julien fixed this bug here bug 925461. I will try to reproduce it, thx

I checked, my change from bug 925461 is still there. But bug 925461 was different: the items were still there _but_ you could not launch them. So it seems this is really a different bug.

We have just seen that it could be a DB VERSION issue

Comment on attachment 8364323 [details] Patch v1 The code looks ok, I'm forwarding to Alexandre who'll check whether this fixes this bug and bug 953406.

I can confirm that it fixes at least bug 953406.

Is this also going to fix a device that already updated from 1.2 to 1.3?

(In reply to Axel Hecht [:Pike] from comment #9) > Is this also going to fix a device that already updated from 1.2 to 1.3? I think so but it should be tested. If this case is not fixed, we should fill a new bug thought

Comment on attachment 8364323 [details] Patch v1 The code is simple enough and fixes this issue and bug 953406, this looks good to me ! Just have to hope that Travis will be green: https://travis-ci.org/mozilla-b2g/gaia/builds/17477320 :)

(In reply to Axel Hecht [:Pike] from comment #9) > Is this also going to fix a device that already updated from 1.2 to 1.3? I did an upgrade from 1.2 to 1.3 that replicates the issue and then I just pushed a fixed version of homescreen, restarted and it was okay. So I would answer yes.

Merged in master: https://github.com/crdlc/gaia/commit/93bea008761b534d8337f7819fc16ba526f686d2

(In reply to Axel Hecht [:Pike] from comment #9) > Is this also going to fix a device that already updated from 1.2 to 1.3? I think it does because the upgrade couldn't finish and therefore will be attempted again.

Sorry about this, I should have caught this in my review in bug 933752, no excuse. We learn every day!

Don't apologize Julien, everybody commit mistakes. Bugs are our friends. Without them we don't have job :) The most important is that it seems fixed. Go for another one! Thanks for your support to fix it mate!

Uplifted 93bea008761b534d8337f7819fc16ba526f686d2 to: v1.3: 5e498acc8cae3251fd9683fc9b1b66d494bb9237

Just tested the latest update on my Keon on 1.3, and I can verify that it fixed the issue.