Closed
Bug 937690
Opened 11 years ago
Closed 10 years ago
[traceback] There are a couple of apps which don't have categories
Categories
(Marketplace Graveyard :: Developer Pages, defect, P4)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: clouserw, Unassigned)
References
Details
This came in from e.me. There are a couple of apps which don't have categories:
> https://marketplace.firefox.com/app/vector-racer-puzzles/
> https://marketplace.firefox.com/app/kiwi-irc/
They currently just ignore those apps, which is fine, but we shouldn't have apps with no categories. More importantly though, when loading the "edit listing" page I get a traceback on those apps:
DoesNotExist: AppFeatures matching query does not exist.
Stacktrace (most recent call last):
File "django/core/handlers/base.py", line 111, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File "amo/decorators.py", line 157, in wrapper
return f(*args, **kw)
File "amo/decorators.py", line 149, in wrapper
return f(*args, **kw)
File "addons/decorators.py", line 33, in wrapper
return f(request, addon, *args, **kw)
File "amo/decorators.py", line 32, in wrapper
return func(request, *args, **kw)
File "mkt/developers/decorators.py", line 36, in wrapper
return fun()
File "mkt/developers/decorators.py", line 28, in <lambda>
*args, **kw)
File "mkt/developers/views.py", line 137, in edit
data['version'].features.to_list()]
File "django/db/models/fields/related.py", line 255, in __get__
rel_obj = self.get_query_set(instance=instance).get(**params)
File "django/db/models/query.py", line 366, in get
% self.model._meta.object_name)
Comment 1•10 years ago
|
||
The AppFeatures issues was already reported in bug 932972 (and the underlying problem is bug 899082 - it's rare, and very difficult to reproduce, which is why we haven't been able to fix it so far).
We should fix the categories issue, that should be easy once bug 987880 lands in production (hopefully today).
Assignee: nobody → mpillard
Depends on: 987880
Comment 2•10 years ago
|
||
There are a bunch of apps with categories = NULL, but vector-racer-puzzles is the only public one. All the others have been deleted/rejected or are incomplete.
Now that categories are stored on the addons table I don't think the issue will come back, we just need to fix vector-racer-puzzles manually. It hasn't been modified in a while, and it's missing a current_version, has no appfeatures, and more importantly no files :(
Reporter | ||
Comment 3•10 years ago
|
||
Maybe it should be disabled. Andrew - can you do whatever needs doing?
Flags: needinfo?(awilliamson)
Comment 4•10 years ago
|
||
well, I've disabled it and contacted the developer. I can't delete it because the status page throws a traceback :)
Flags: needinfo?(awilliamson)
Comment 5•10 years ago
|
||
No longer affects public apps ; there is another bug opened for the underlying problem.
Assignee: mpillard → nobody
Priority: P2 → P4
Reporter | ||
Comment 6•10 years ago
|
||
This is either a wontfix or a dupe of bug 932972. Either way, it's out of date.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•