Closed
Bug 987880
Opened 11 years ago
Closed 10 years ago
Categories should in settings and stored on apps/collections as a simple list of ids
Categories
(Marketplace Graveyard :: Developer Pages, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
2014-07-22
People
(Reporter: mat, Assigned: mat)
References
Details
(Keywords: perf, Whiteboard: [repoman])
This is the zamboni side of bug 968312.
We rarely add/remove/change categories, they should be constants like regions and carriers, and we should simply store a list of ids on the Collection/Webapp models instead of doing FKs to the database. There would be a small perf gain, although not really for the consumer pages - in bug 968312 we already made fireplace load a static list of categories instead of requesting the list of all existing ones from the API.
This is blocked on Guillotine because the Category model is also used by AMO and that would be much more difficult to fix there.
Updated•11 years ago
|
Whiteboard: [incorrect_implementation]
Updated•11 years ago
|
Blocks: tarako-marketplace
Updated•11 years ago
|
No longer blocks: tarako-marketplace
Assignee | ||
Comment 1•11 years ago
|
||
Note: there is some ground work done in https://github.com/mozilla/zamboni/commit/76927e730e7a8ac0d08a32dfeed4f43fbe6828c1 - the categories list introduced in this commit will probably need to move when we implement the rest of this bug.
Assignee | ||
Updated•10 years ago
|
Whiteboard: [incorrect_implementation] → [repoman]
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
Fixed in https://github.com/mozilla/zamboni/commit/0214acab25fa1d078c4f43373bf8805293534078
QA: please try to find regressions around app categories :)
- Test that browsing categories work fine on the consumer pages
- Test that submitting an app works, including selecting categories
- Test that reviewing an app works, and the categories should be shown on the reviewers detail page.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2014-07-22
Comment 3•10 years ago
|
||
App submission is currently blocked by Bug 1028908.
Comment 4•10 years ago
|
||
Verified as fixed in marketplace-dev.allizom.org FF33 (Win7)
New app submission including category selection: http://screencast.com/t/Y8FEUi67pgO
App review: http://screencast.com/t/RPxV5FyE
Browsing categories: http://screencast.com/t/fRtKdjga
Closing.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•