Payments now will access ICC info from Bug 892068, however in multi-SIM we need to process all SIMs instead of only one.

I won't be able to work on this until late next week, so feel free to steal it from me if someone else is able to do it before.

Is this still true? It seems like we just need to get the information from the primary SIM.

As Yoshi mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=936471#c19 this is still a valid bug and it is currently blocked by the DSDS feature. I'm removing myself as assignee until the required DSDS bits are done.

cc'ing wesj. This will affect the Android implementation (when we have it).

I am not sure why this bug depends on bug 936325. Bug 936325 is talking about an advanced feature to turn on/off a 'specific' 'single' SIM card, instead of putting them both into airplane mode at the same time, while IMHO what payment needs is to get the 'standby/ready' sim cards. If my understanding is correct, the current MobilConnection and IccManager API already provide the necessary information.

You are right Hsin-Yi. The dependency was added because of the confusion between primary and active SIM in the comments from bug 936471

Fabrice, you can find the rationale behind this changes in https://wiki.mozilla.org/WebAPI/WebPayment/Multi-SIM#Firefox_OS_v1.4 This patch shouldn't land until bug 961794 is fixed.

Comment on attachment 8363870 [details] [diff] [review] v1 Review of attachment 8363870 [details] [diff] [review]: ----------------------------------------------------------------- ::: b2g/chrome/content/payment.js @@ +107,5 @@ > }; > > function PaymentSettings() { > + try { > + this.numRadioInterfaces = Services.prefs.getIntPref(PREF_NUM_RADIO_INTERFACES); Why not use nsIRadioInterfaceLayer::numRadioInterfaces ? @@ +181,5 @@ > try { > let setting = JSON.parse(aData); > + if (!setting.key || > + setting.key !== kRilDefaultDataServiceId || > + setting.key !== kRilDefaultPaymentServiceId) { I think you want: (!setting.key || (setting.key !== kRilDefaultDataServiceId && setting.key !== kRilDefaultPaymentServiceId))

Thanks Fabrice, this patch addresses your comments.

Thanks Fabrice! https://hg.mozilla.org/integration/b2g-inbound/rev/1f992b7b3f3a