Fernando Jiménez Moreno [:ferjm] Assignee
	Description • 11 years ago

Before Bug 938993 lands we need to make sure that the server side supports the API changes and it still keeps working with old API versions.

	Fernando Jiménez Moreno [:ferjm] Assignee
	Comment 1 • 11 years ago

Kumar, these changes are based on the platform patch proposed for Bug 938993. Basically, I removed the .iccIds, .mcc and .mnc properties from the mozPaymentProvider API and introduced a new iccInfo object containing all this values indexed by payment service ID. This patch in WebPay is just to make sure that we don't break the server flow when we land the client changes. The algorithm described in [1] (that I need to rewrite) still needs to be implemented, I guess, as part of Bug 942361.

I didn't find any reference to .mcc or .mnc so I guess that these values are being accessed by Bango and so we also need a patch on their side to make sure that the client changes don't break their flow.

Unfortunately, I cannot test this patch locally with the whole WebPay flow :(.

Would you mind taking a look at the code and testing the patch, please?

Thanks!

	Kumar McMillan [:kumar]
	Comment 2 • 11 years ago

Comment on attachment 8362991 [details]
v1

Patch merged: https://github.com/mozilla/webpay/commit/9a95c6d20e7e40beff5f8ba74bb048cf5db918d3 Thanks again.

	Kumar McMillan [:kumar]
	Comment 3 • 11 years ago

For QA, these are the STR:

- flash Firefox OS version >= 1.4 on a device with a SIM (check the console for this log message when beginning a payment: 'mozPaymentProvider.iccInfo?')
- start a payment
- when it says confirm your mobile number, proceed until you see a buy screen
- shut down the device
- remove or swap the SIM
- restart and begin a new payment

Expected: you should be asked to confirm your mobile number *again* since you inserted a new SIM.

	Iulian Timis
	Comment 4 • 11 years ago

I have flashed my Inari with FF OS 1.4 but when I tap on the price button to buy an app, nothing happens.
Do you want me to file a new bug with this issue? Thank you.
Log ID: 9fd99

	Fernando Jiménez Moreno [:ferjm] Assignee
	Comment 5 • 11 years ago

You need to wait for bug 938993 to land in mozilla-central.

	Fernando Jiménez Moreno [:ferjm] Assignee
	Comment 6 • 11 years ago

Actually, it should work even without bug 938993. Any errors in the logcat?

	Iulian Timis
	Comment 7 • 11 years ago

I have attached the logcat for the issue described above.

	Fernando Jiménez Moreno [:ferjm] Assignee
	Comment 8 • 11 years ago

This looks like bug 963582