Closed
Bug 939118
Opened 11 years ago
Closed 11 years ago
DisconnectStep shouldn't do anything if the slave is in the middle of a graceful shutdown
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
Attachments
(1 file)
(deleted),
patch
|
rail
:
review+
emorley
:
feedback+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
Arguably, if you've requested a graceful shutdown of a slave, you don't want it to reboot. It's kindof pointless, really, and harmful if you didn't or can't disable it in slavealloc for some reason. Also this would help a lot with bug 932392.
I'm a little biased in my desire for this, so what do folks think? I tested this in staging.
Attachment #832925 -
Flags: review?(emorley)
Attachment #832925 -
Flags: review?(catlee)
Assignee | ||
Comment 1•11 years ago
|
||
Rail just pointed out a more solid use case for this: it will allow us to grab files before puppet cleans them up at start-up time. This won't help with nightly builds where we rm the dir as part of the build, but it will help in cases where there's files in temp dirs or other locations like that.
Comment 2•11 years ago
|
||
Comment on attachment 832925 [details] [diff] [review]
don't reboot when graceful shutdown is set
sgtm :-)
Attachment #832925 -
Flags: review?(emorley) → feedback+
Updated•11 years ago
|
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Updated•11 years ago
|
Attachment #832925 -
Flags: review?(catlee) → review?(rail)
Updated•11 years ago
|
Attachment #832925 -
Flags: review?(rail) → review+
Assignee | ||
Updated•11 years ago
|
Attachment #832925 -
Flags: checked-in+
Comment 3•11 years ago
|
||
something[s] here made it to production
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•