Closed
Bug 93936
Opened 24 years ago
Closed 24 years ago
"Work Offline" text in status bar is very unclear
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.4
People
(Reporter: benjamin, Assigned: hewitt)
References
Details
(Keywords: polish, Whiteboard: [br])
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC; en-US; rv:0.9.3+) Gecko/20010806
BuildID: 2001080608
The "Work" should be remove because it's a "Status" Bar and the other option
(Work online) isn't displayed in same time. Offline/Online should be enough to
discribe the ACTUAL state not the state AFTER clicking... at least IMO.
Comment 1•24 years ago
|
||
probably should be "working." mpt: what do you think?
Zach
Reporter | ||
Comment 2•24 years ago
|
||
In fact why the icon isn't enough..?
Anyone know if this related to this bug, 43406?
or is there another bug out there that landed this
option?
The text should not be there at all. On hover over, a tooltip with that text
should appear though.
Comment 5•24 years ago
|
||
I agree with Jennifer here. The text is misleading and distracting, and takes up
valuable status bar space. It should be removed completely. There are other bugs
on making the online/offline icon clearer.
--> XP Apps/GUI, normal severity because of the high visibility of the problem.
Assignee: mpt → blake
Severity: enhancement → normal
Status: UNCONFIRMED → NEW
Component: User Interface Design → XP Apps: GUI Features
Ever confirmed: true
Keywords: polish
QA Contact: zach → sairuh
Updated•24 years ago
|
QA Contact: sairuh → claudius
Comment 6•24 years ago
|
||
what do we think of the icon's current tooltip? What about just cutting out
the text and leaving the icon and tooltip as they are now?
Comment 7•24 years ago
|
||
How did this get checked-in in the first place?
The tooltip currently reads: "You are online|offline. Click the icon to go
offline|online" It's been like that for a long time, no need to change.
The actual words next to the connected plug icon that read "Work (Off|On)line"
very much need to go away and that's the final answer, regis.
Comment 8•24 years ago
|
||
This text should always have been there from a code perspective, but somehow
hewitt exposed it with his box cleanup.
Assignee: blake → hewitt
Comment 9•24 years ago
|
||
Okay, I figured out how to fix this puppy.
look at
http://lxr.mozilla.org/seamonkey/source/xpfe/communicator/resources/content/utilityOverlay.xul#27
What needs to be removed is the line that says:
label="&offlineGoOfflineCmd.label;"
That is causing the label to appear in the first place.
Then look at
http://lxr.mozilla.org/seamonkey/source/xpfe/communicator/resources/content/utilityOverlay.js#78
What needs to be removed there are the two lines that say:
broadcaster.setAttribute("label", bundle.GetStringFromName("goonline"));
and
broadcaster.setAttribute("label", bundle.GetStringFromName("gooffline"));
Which change the label when your online/offline state changes.
With those three lines removed or commented out, the icky label dies.
Somebody else is going to have to make a patch for this, I dont have a
development system, I just tested the fix by hacking the jar files on the
2001081003 Win95 nightly build.
Comment 10•24 years ago
|
||
Yes, and then what happens when you go off and online? Does the menuitem label
change in the File menu?
Comment 11•24 years ago
|
||
D'oh! yeah, you are right. That label in the file menu isnt changing when I go
offline and online now :(
Comment 12•24 years ago
|
||
*** Bug 93715 has been marked as a duplicate of this bug. ***
Comment 13•24 years ago
|
||
Question for somebody who knows:
look at the CSS class statusbarpanel-icononly defined in global.css
.statusbarpanel-icononly {
padding: 0px;
}
This is the class used by the online/offline icon, the security lock icon, and
probably a number of other statusbar icons.
I see nothing there that makes it textless. Is there supposed to be a CSS rule
in there that somehow prevents the text from appearing? Or is the textlessness
of statusbarpanel-icononly defined elsewhere? Or are people using
statusbarpanel-icononly simply expected, on their honor, not to assign a label
to it?
I observed (and yes I am aware this is a bad thing to do, and does not even
remotely resemble a satisfactory fix) I observed that if I changed this to:
.statusbarpanel-icononly {
max-width: 32px;
padding: 0px;
}
I fixed the symptoms (of course, I probably screw up things elsewhere too)
so anyway. my point is, is there something more that needs to go in
statusbarpanel-icononly ? some kind of magical "text-display:disabled;" or
"label:hidden;" or some such thing like that?
Comment 14•24 years ago
|
||
Oh, hey. I *might* have just answered my own question...
It appears that the entire purpose of
/xpfe/communicator/resources/content/utilityOverlay.css is to prevent the text
from displaying on the offline-status thingy, which is of class
statusbarpane-icononly
here is the entire file, all 8 lines of it:
/**
* Essential behaviour styles for Communicator package
**/
#offline-status > .statusbar-panel-text
{
display: none;
}
Comment 15•24 years ago
|
||
mozillauser: try removing the XUL line but leaving the broadcasters.
Gerv
Comment 16•24 years ago
|
||
There we go. That's the reason. hewitt added a box to statusbarpanel so that
style rule is failing. Not that that's not incredibly lame anyways (having the
text but hiding it).
Whiteboard: [br]
Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 17•24 years ago
|
||
fixed
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•24 years ago
|
Target Milestone: --- → mozilla0.9.4
Comment 18•24 years ago
|
||
Please do not remove the text, only hide it. It allows skin designers to create
icon-free skins. I had thought there was a bug on adding text for the
online/offline button, but maybe I only asked about it.
Comment 19•24 years ago
|
||
This the bug you are talking about Eric, bug 43406?
Comment 20•24 years ago
|
||
That isn't the bug I was thinking of, it was only skinnability minded and
probably only discussed on IRC. I just wanted to make sure the status text
would stay but remain hidden. (Like the modern nav buttons don't have Back,
Forward, Reload, Stop, etc., but the text is still there for classic.)
Comment 21•24 years ago
|
||
*** Bug 96996 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•