Closed Bug 941175 Opened 11 years ago Closed 11 years ago

[User Story] [Meta] Browser Chrome: View URL

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

x86
macOS
defect
Not set
normal

Tracking

(feature-b2g:2.0, tracking-b2g:backlog, b2g-v2.0 disabled)

RESOLVED FIXED
feature-b2g 2.0
tracking-b2g backlog
Tracking Status
b2g-v2.0 --- disabled

People

(Reporter: pdol, Unassigned)

References

Details

(Whiteboard: [ucid:System125, 1.4:P2, ft:systems-fe], system-browser,[systemsfe] )

Attachments

(1 file)

User Story: As a user I want to view the URL of the web page I'm currently on so that I can see which website I am currently viewing. Acceptance Criteria: Functionality should match existing Browser functionality unless described otherwise in UX spec.
Let's try to start here.
Assignee: nobody → bfrancis
Working on a Frankenstein branch off Alive's window manager branch + Dale's Browser2 icon patch, until Alive's new window manager lands. https://github.com/benfrancis/gaia/tree/system-browser
Depends on: 940989
Component: Gaia::System → Gaia::System::Browser
No longer blocks: browser-chrome-mvp
Switched to a new branch on top of the rocketbar feature branch https://github.com/benfrancis/gaia/tree/941175 Problem is I also need to integrate with Alive's new Window Manager which is currently on the other branch...
For a moment I thought this had already been implemented on master. If you type a URL into the Rocketbar it opens a new browser window, then if you open the Rocketbar again it will show the URL of the web page. But if you try to view the URL in the browser window opened by the Browser2 icon you'll see that it doesn't work. I think that's because the URL shown in the above case is actually what the cards view is reporting as the title of the window. I'm going to work on a more complete implementation which actually uses locationchange events and keeps track of the current URL as a property of Rocketbar.
Estimating as 2 points.
Whiteboard: [ucid:System125, 1.4:P2, ft:systems-fe], system-browser → [ucid:System125, 1.4:P2, ft:systems-fe], system-browser, [p=2]
Comment on attachment 8365143 [details] https://github.com/mozilla-b2g/gaia/pull/15687 Implementation looks good, few minor comments but they dot particularly need addressed, however this patch very definitely needs integration tests, those unit tests dont cover much surface area and this type of feature is perfect for testing, will clear review for now
Attachment #8365143 - Flags: review?(dale)
Urgh. It looks like this now has merge conflicts with all the Rocketbar patches currently landing on master (without integration tests) in the great "let's land the half-baked prototype Rocketbar in master" initiative over in bug 959353. I'll look at this tomorrow.
OK, I've resolved all the conflicts. https://github.com/mozilla-b2g/gaia/pull/15687 I'll now look at ramping up integration tests for the Rocketbar inside the system app.
Target Milestone: --- → 1.3 C3/1.4 S3(31jan)
Whiteboard: [ucid:System125, 1.4:P2, ft:systems-fe], system-browser, [p=2] → [ucid:System125, 1.4:P2, ft:systems-fe], system-browser, [p=2] [systemsfe]
Target Milestone: 1.3 C3/1.4 S3(31jan) → 1.4 S1 (14feb)
Flags: in-moztrap?(nhirata.bugzilla)
Depends on: 968832
Whiteboard: [ucid:System125, 1.4:P2, ft:systems-fe], system-browser, [p=2] [systemsfe] → [ucid:System125, 1.4:P2, ft:systems-fe], system-browser,[systemsfe]
Target Milestone: 1.4 S1 (14feb) → ---
Turning this into a meta bug. This never landed because it didn't have r+ but Kevin has now done a part implementation in a dependent bug which we will use instead and track any follow-up work as blocking this user story.
Assignee: bfrancis → nobody
Summary: [User Story] Browser Chrome: View URL → [User Story] [Meta] Browser Chrome: View URL
No longer blocks: 1.4-systems-fe
This landed but wasnt closed out
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
blocking-b2g: --- → backlog
feature-b2g: --- → 2.0
Flags: in-moztrap?(nhirata.bugzilla) → in-moztrap+
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: