Closed
Bug 968832
Opened 11 years ago
Closed 11 years ago
[Rocketbar] Edit URL implementation
Categories
(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.4 S1 (14feb)
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [p=2],[systemsfe],system-browser)
Attachments
(1 file)
It would be nice to allow editing of URLs.
|
Assignee | |
Comment 1•11 years ago
|
||
This is a basic implementation for viewing and editing the the current URL.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8371523 [details]
Github pull request
Alive - would you have a quick chance for a review here as well? Thanks!
Attachment #8371523 -
Flags: review?(alive)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8371523 [details]
Github pull request
Swapping review to ben or vivien as i think they might have more time, and I have other reviews for alive :)
Attachment #8371523 -
Flags: review?(bfrancis)
Attachment #8371523 -
Flags: review?(alive)
Attachment #8371523 -
Flags: review?(21)
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [p=2],[systemsfe],system-browser
|
||
Updated•11 years ago
|
Target Milestone: --- → 1.4 S1 (14feb)
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8371523 [details]
Github pull request
Note that "the URL of the page that opened the Rocketbar" isn't the same thing as "the current URL", which is what we really need the Rocketbar to show. That's why I keep currentURL updated via locationchange events in https://github.com/mozilla-b2g/gaia/pull/15687
For now this won't be very noticeable, but will become more important as we get closer to the UX spec.
This patch will do as a start.
Did you file a bug to write integration tests?
Attachment #8371523 -
Flags: review?(bfrancis) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 8371523 [details]
Github pull request
Thanks. I've filed bug 970390 to track writing integration tests.
Attachment #8371523 -
Flags: review?(21)
|
|
Assignee | |
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•