Based on the objectives in: https://etherpad.mozilla.org/newclobberer Code will live here initially: http://hg.mozilla.org/users/jhopkins_mozilla.com/newclobberer/

Need to put this on the back burner while I work on bug 886640. Happy to review any contributed code, however!

This minimal implementation has been tested with the client and the current clobberer db implementation for compatibility.

Comment on attachment 8504147 [details] GitHub PR (reviewed on github)

Please let me know if I'm driving you all nutty and should request reviews from more folks.

Comment on attachment 8505939 [details] relengapi-clobberer endpoint which replicates always_clobber.php behavior reviewed on github, r+

Client tests and tests using a private buildmaster are working with these changes: http://dev-master1.srv.releng.scl3.mozilla.com:8046/builders/WINNT%205.2%20try%20build/builds/21/steps/checking_clobber_times/logs/stdio

Comment on attachment 8506349 [details] [diff] [review] swapping out clobberer api in staging configs The patch is trivial, let's save some time for bhearsum/catlee

Comment on attachment 8506364 [details] [diff] [review] swapping out clobberer api in staging configs (mozharness) ship it!

Just keeping things in sync between BZ and GH

This has been tested with old clobberer for backwards compatibility with good success.

Ben, I got good feedback about the code; but would feel good if you gave this a final thumbs up before I merge since we discussed it on IRC.

Comment on attachment 8506349 [details] [diff] [review] swapping out clobberer api in staging configs https://hg.mozilla.org/build/buildbot-configs/rev/9ed7b194f428

Comment on attachment 8506364 [details] [diff] [review] swapping out clobberer api in staging configs (mozharness) https://hg.mozilla.org/build/mozharness/rev/1ad50eb7f82a

(In reply to Rail Aliiev [:rail] from comment #15) > Comment on attachment 8506349 [details] [diff] [review] > swapping out clobberer api in staging configs > > https://hg.mozilla.org/build/buildbot-configs/rev/9ed7b194f428 FTR, I had to skip the esr24 related hunks. esr24 is dead! :)

In production: https://hg.mozilla.org/build/buildbot-configs/rev/9ed7b194f428

In production: https://hg.mozilla.org/build/mozharness/rev/1ad50eb7f82a

Comment on attachment 8509643 [details] Remove users' ability to see release builds I think this is no longer needed because the PR is closed?

Ben, this took your suggestion to the previous PR into account. I caused a nasty merge situation in the other pull request and decided to abandon it (Travis wasn't working because of the merge errors).

Comment on attachment 8510396 [details] Remove users' ability to see/clobber release builds I left one comment on the PR, but nothing that blokcs.

Everything's done on clobberer that needs doing until the old clobberer is deprecated, you can see the status here: https://etherpad.mozilla.org/newclobberer

Comment on attachment 8507904 [details] Adds Angular UI addressed in github

Just a message in an h1 tag

I waited a bit on these because I wasn't familiar with them. Looked them over, and this seems right. Mostly these were just fallback values hard coded into the script.

In production: https://hg.mozilla.org/build/buildbot-configs/rev/7c491b4779c1

In production: https://hg.mozilla.org/build/mozharness/rev/dd409298ca1a

Closing this task, since it's now a part of the production configs. I'll make smaller bugs to cover any small cleanup tasks.

Do we have bugs on file already to: 1) bring down old clobberer (https://secure.pub.build.mozilla.org/clobberer/) 2) remove old clobberer service from source control (under http://hg.mozilla.org/build/tools/file/e61d4d45346d/clobberer) 3) remove references to old clobber from the wiki (https://wiki.mozilla.org/ReleaseEngineering/Applications/Clobberer) 4) update mana pages: https://mana.mozilla.org/wiki/display/IT/Clobberer https://mana.mozilla.org/wiki/pages/viewpage.action?pageId=24805981 5) Remove CNAME records from inventory (https://inventory.mozilla.org/en-US/core/search/#q=clobberer) 6) decommission old clobberer servers 7) clean up old nagios checks for the old clobberer environments Other possible work: 1) I see a seamonkey-clobberer.mozilla.org CNAME in inventory, but I don't think we are hosting any seamonkey builders, can we decomm that too? (question for Callek) 2) I couldn't find references to the old clobberer service in our puppet repo - but is that managed by an IT puppet repo instead? If so, maybe we need to pull it too (or ask IT to pull it). 3) Are there any secrets stored anywhere which should be cleaned up relating to the old service? Apologies if some or all of this is covered elsewhere already. Thanks, Pete

(In reply to Morgan Phillips [:mrrrgn] from comment #36) > Closing this task, since it's now a part of the production configs. I'll > make smaller bugs to cover any small cleanup tasks. Sorry, only just seen this! :D Hopefully the list is useful anyway.

(In reply to Pete Moore [:pete][:pmoore] from comment #38) > Other possible work: > 1) I see a seamonkey-clobberer.mozilla.org CNAME in inventory, but I don't > think we are hosting any seamonkey builders, can we decomm that too? > (question for Callek) Just to answer, we can't kill off that CNAME. Mozilla does host seamonkeys machines, but 'releng' does not, they are completely managed by community (which includes me though). That CNAME is necessary last I checked, and doesn't point to any of the managed-by-releng systems.

(In reply to Justin Wood (:Callek) from comment #40) > (In reply to Pete Moore [:pete][:pmoore] from comment #38) > > Other possible work: > > 1) I see a seamonkey-clobberer.mozilla.org CNAME in inventory, but I don't > > think we are hosting any seamonkey builders, can we decomm that too? > > (question for Callek) > > Just to answer, we can't kill off that CNAME. Mozilla does host seamonkeys > machines, but 'releng' does not, they are completely managed by community > (which includes me though). > > That CNAME is necessary last I checked, and doesn't point to any of the > managed-by-releng systems. Will it cause seamonkey any problems if we deprecate the old clobberer? For example, do they rely on our tools repo, or do they have their own fork?

It's forked. The rest of this plan looked good to me

For anyone else who was struggling to find the new RoR (the repo in comment 0 is out of date, and the various Mana/wiki pages don't link to the source afaict), it's here: https://github.com/mozilla/build-relengapi-clobberer I've also filed an issue for adding links to the source in the footer of the clobberer: https://github.com/mozilla/build-relengapi-clobberer/issues/31

Just as an fyi, all our repos are now listed at https://wiki.mozilla.org/ReleaseEngineering/Repositories as well