Closed
Bug 945351
Opened 11 years ago
Closed 11 years ago
Increase the number of chunks for B2G debug mochitests
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jgriffin, Assigned: jgriffin)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
(deleted),
patch
|
mozilla
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
We're currently running 9 chunks, but these may be too long (at any rate, they commonly exceed 60 minutes). We should expand this to at least 12 chunks.
Comment 1•11 years ago
|
||
jgriffin: thanks for filing this. Ideally we'd like each specific job to run 25-30 mins... If we can do that with "only" 12 chunks great... if we need more chunks, go for it!
Assignee | ||
Comment 2•11 years ago
|
||
It's very likely we'll need more chunks then...we can try with 15 initially.
Assignee | ||
Comment 3•11 years ago
|
||
AFAICT, there's no way to change just the number of debug chunks without introducing a new test suite name, e.g., mochitest-debug-1, instead of mochitest-1. I think we are forced to choose either introducing a new suite name, or increasing the number of opt chunks as well.
We'd have to update TBPL to understand the new suite name, if we went that route, as well as downstream consumers like OrangeFactor. On the other hand, increasing the number of opt chunks would increase our compute hours per commit, due to the overhead of the additional setup/teardown times.
releng, do you have a preference here?
Flags: needinfo?(catlee)
Flags: needinfo?(aki)
Comment 4•11 years ago
|
||
Hm, I don't have strong opinions, but:
assuming debug tests will take longer forever (or for the long term, at least), that would probably mean we want a different number of chunks for the long term, and the mochitest-debug-# would make sense. I think this is the case, but I'm not sure.
If debug tests are going to converge with opt tests in terms of runtime in the short- or medium-term (not sure if this is possible, but if), increasing the total number of opt+debug chunks (or having slightly fewer debug chunks that take longer) might make sense.
Flags: needinfo?(aki)
Assignee | ||
Comment 5•11 years ago
|
||
I think debug tests will run much slower for the foreseeable future. I'll go with the different suite name.
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #8341497 -
Flags: review?(aki)
Comment 7•11 years ago
|
||
This looks good.
Comment 8•11 years ago
|
||
Comment on attachment 8341497 [details] [diff] [review]
Use 15 chunks for debug B2G mochitests,
Thanks Jonathan!
Attachment #8341497 -
Flags: review?(aki) → review+
Comment 9•11 years ago
|
||
agree with Aki, just note that we'll see possibly different test behaviour because of different chunking between opt and debug.
Flags: needinfo?(catlee)
Comment 10•11 years ago
|
||
And different developer behavior, since most people think that if they look in one log and find that the test they are working on runs in (opt) m-5, then they can use try: -b do -p emulator -u mochitest-5 to run their test on opt and debug.
Comment 11•11 years ago
|
||
We can fix those issues if they become a real problem. Right now we have to get debug emulator tests running.
Assignee | ||
Comment 12•11 years ago
|
||
https://hg.mozilla.org/build/buildbot-configs/rev/7fd217b1cee3
Note that when this goes live, we'll need to update TBPL to handle the new suite name.
Comment 13•11 years ago
|
||
in production
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•