(no longer active) Reporter
	Description • 11 years ago

See the dev.platform discussion.

glandium, can you please take this, or tell me what the magical flag to test for in configure.in is so that I can take it myself?  Thanks!

	Mike Hommey [:glandium] Assignee
	Comment 2 • 11 years ago

Until we can do something better

	(no longer active) Reporter
	Comment 3 • 11 years ago

Comment on attachment 8341379 [details] [diff] [review]
Disable unified builds on tbpl debug builds

Review of attachment 8341379 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not convinced that we should do this for now.  I would like us to address these kinds of bustages with a lower priority than backing out the patch immediately, so I don't want them to turn debug builds red.

(And this should go into its own bug if we want to re-evaluate anyway.)

	Mike Hommey [:glandium] Assignee
	Comment 4 • 11 years ago

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #3)
> Comment on attachment 8341379 [details] [diff] [review]
> Disable unified builds on tbpl debug builds
> 
> Review of attachment 8341379 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm not convinced that we should do this for now.  I would like us to
> address these kinds of bustages with a lower priority than backing out the
> patch immediately, so I don't want them to turn debug builds red.
> 
> (And this should go into its own bug if we want to re-evaluate anyway.)

The thing is, with the first patch, we run in a serious chance of busting aurora when merging. I'm running non-unified builds on birch, which kind of helps, but i already hit two different build failures that slipped in within the past 10 hours.

	Mike Hommey [:glandium] Assignee
	Comment 5 • 11 years ago

And yes, i do think at 7 days from the merge, we should start being proactive, not reactive. Also, those errors should be fixed by the people that land them, not you and me.

	Mike Hommey [:glandium] Assignee
	Comment 6 • 11 years ago

(In reply to Mike Hommey [:glandium] from comment #4)
> The thing is, with the first patch, we run in a serious chance of busting
> aurora when merging. I'm running non-unified builds on birch, which kind of
> helps, but i already hit two different build failures that slipped in within
> the past 10 hours.

And a third one just landed.

	(no longer active) Reporter
	Comment 7 • 11 years ago

Comment on attachment 8341379 [details] [diff] [review]
Disable unified builds on tbpl debug builds

OK, let's give it a shot, I guess...  Please post to dev-platform on a new thread before landing this.  Thanks!

	Mike Hommey [:glandium] Assignee
	Comment 8 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/cf52d24c12b6
https://hg.mozilla.org/mozilla-central/rev/1fe0178cd92d

	(no longer active) Reporter
	Comment 9 • 11 years ago

So is this fixed now?

	Mike Hommey [:glandium] Assignee
	Comment 10 • 11 years ago

Ah yes, I'm too used to landing on inbound.

	(not currently active) Ted Mielczarek
	Comment 11 • 10 years ago

(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #0)
> See the dev.platform discussion.

For future reference, this was: https://lists.mozilla.org/pipermail/dev-platform/2013-December/002393.html