Closed
Bug 946576
Opened 11 years ago
Closed 11 years ago
Disable unified builds on all debug builds
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #945496 +++ Bug 945496 disabled for browser, but not b2g/android/xulrunner. And guess what, a build error already slipped in for android.
Assignee | ||
Updated•11 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Assignee | ||
Comment 1•11 years ago
|
||
There aren't debug builds on all platforms for b2g, so i just enabled everywhere. Likewise for xulrunner.
Attachment #8342873 -
Flags: review?(ehsan)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Updated•11 years ago
|
Attachment #8342873 -
Flags: review?(ehsan) → review+
![]() |
||
Comment 2•11 years ago
|
||
Is this because of problems on tbpl only? I'm very happy with unified builds, it speeds up builds so much for me locally! Can I opt-out when building locally? What problems can I expect then?
Comment 3•11 years ago
|
||
(In reply to Honza Bambas (:mayhemer) from comment #2) > Is this because of problems on tbpl only? I'm very happy with unified > builds, it speeds up builds so much for me locally! Can I opt-out when > building locally? What problems can I expect then? if you read the patch you'll see it just changes the in tree mozconfigs which you shouldn't be using anyway so it has no effect.
![]() |
||
Comment 4•11 years ago
|
||
(In reply to Trevor Saunders (:tbsaunde) from comment #3) > (In reply to Honza Bambas (:mayhemer) from comment #2) > > Is this because of problems on tbpl only? I'm very happy with unified > > builds, it speeds up builds so much for me locally! Can I opt-out when > > building locally? What problems can I expect then? > > if you read the patch you'll see it just changes the in tree mozconfigs > which you shouldn't be using anyway so it has no effect. The in-tree mozconfig structure is not clear to ordinary mortals ;) Thanks for explanation!
Comment 5•11 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #1) > Created attachment 8342873 [details] [diff] [review] > Disable unified builds on b2g and xulrunner builds, and android debug builds > > There aren't debug builds on all platforms for b2g, so i just enabled > everywhere. Likewise for xulrunner. Why XULRunner?
Comment 6•11 years ago
|
||
(In reply to comment #5) > (In reply to Mike Hommey [:glandium] from comment #1) > > Created attachment 8342873 [details] [diff] [review] > > Disable unified builds on b2g and xulrunner builds, and android debug builds > > > > There aren't debug builds on all platforms for b2g, so i just enabled > > everywhere. Likewise for xulrunner. > > Why XULRunner? Because it can also break in similar ways to other types of builds.
Assignee | ||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/258bb2ea7c1a
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Comment 8•11 years ago
|
||
(In reply to Trevor Saunders (:tbsaunde) from comment #3) > if you read the patch you'll see it just changes the in tree mozconfigs > which you shouldn't be using anyway so it has no effect. Except for b2g, where gonk-misc/default-gecko-config (which is used for all builds, local and tinderbox and whatever else) includes gecko/b2g/config/mozconfigs/common.
Comment 9•11 years ago
|
||
Shoot! Mike, can you please see if you can do something to avoid putting this into b2g/config/mozconfigs/common?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 10•11 years ago
|
||
(In reply to Jed Davis [:jld] from comment #8) > (In reply to Trevor Saunders (:tbsaunde) from comment #3) > > if you read the patch you'll see it just changes the in tree mozconfigs > > which you shouldn't be using anyway so it has no effect. > > Except for b2g, where gonk-misc/default-gecko-config (which is used for all > builds, local and tinderbox and whatever else) includes > gecko/b2g/config/mozconfigs/common. How does one discriminate between local builds and tinderbox builds in this wonderful system?
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #9) > Shoot! Mike, can you please see if you can do something to avoid putting > this into b2g/config/mozconfigs/common? Please file a followup. B2G developers can live with slower builds until the merge, which is on monday.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•