Eric Pang [:epang] UX Reporter
	Description • 11 years ago

Update the toolbar and tab bar building blocks.  Specs attached.

	Pavel Ivanov [:ivanovpavel][:pivanov] UX Assignee
	Comment 2 • 11 years ago

Comment on attachment 8343598 [details]
patch for Gaia/master

Hey Vivien I think now you can help to review this one :) we separate bug 940520 to few small bugs for each app and this one for the [BB] ;) thanks in advance :)

	Eric Pang [:epang] UX Reporter
	Comment 4 • 11 years ago

Hey Kaze, I just wanted to note that the patch from this bug needs is dependent with the patch from https://bugzilla.mozilla.org/show_bug.cgi?id=947093

They will land together along with all other toolbar updates to remain consistent. Thanks!

	Fabien Cazenave [:kaze]
	Comment 5 • 11 years ago

(In reply to Eric Pang [:epang] from comment #4)
> Hey Kaze, I just wanted to note that the patch from this bug needs is
> dependent with the patch from
> https://bugzilla.mozilla.org/show_bug.cgi?id=947093

Hi Eric, I think there’s a copy/paste mistake here (bug depending on itself). Can you rephrase?

	Eric Pang [:epang] UX Reporter
	Comment 6 • 11 years ago

(In reply to Fabien Cazenave [:kaze] from comment #5)
> (In reply to Eric Pang [:epang] from comment #4)
> > Hey Kaze, I just wanted to note that the patch from this bug needs is
> > dependent with the patch from
> > https://bugzilla.mozilla.org/show_bug.cgi?id=947093
> 
> Hi Eric, I think there’s a copy/paste mistake here (bug depending on
> itself). Can you rephrase?

yes, sorry about that.  There's a bunch of patches that are dependent on this one since this effects the building blocks...so my previous comment isn't relevant to this patch, but in order to see many of the updates this patch needs to be merged with the patches created per app. Thanks!

	Fabien Cazenave [:kaze]
	Comment 7 • 11 years ago

Comment on attachment 8343598 [details]
patch for Gaia/master

Good to see we’re dropping the ugly `data-items` attribute in favor of flexbox!
See remarks on the pull request, and please r? me again when you’re ready.

	Pavel Ivanov [:ivanovpavel][:pivanov] UX Assignee
	Comment 8 • 11 years ago

Comment on attachment 8343598 [details]
patch for Gaia/master

Thanks Kaze :)

I'm done with fixes/rebase and we just waiting answer from Eitan

	Fabien Cazenave [:kaze]
	Comment 9 • 11 years ago

Comment on attachment 8343598 [details]
patch for Gaia/master

LGTM. Please land this patch along with the ones it depends on, so that we don’t break Gaia three days before the X-mas holiday.

The question I asked Eitan on github is a bit orthogonal (= tracking the use of disabled/aria-disabled and selected/aria-selected attributes in Gaia), so I’d say it shouldn’t prevent you from merging it when you’re ready.

	Eitan Isaacson [:eeejay]
	Comment 10 • 11 years ago

To be honest, the use of aria-* and role attributes for css selectors is kind of a headache. Sometimes we find out that a certain role or aria state should be applied to the child or parent of the styled element, or that aria is being misused altogether. In those cases it gets hard to change the markup, since the style selectors depend on it.

Also, this work seems to be very similar to changes Yura is proposing in bug #923139.

	Eitan Isaacson [:eeejay]
	Comment 11 • 11 years ago

(In reply to Eitan Isaacson [:eeejay] from comment #10)
> In those cases it gets hard to change the
> markup, since the style selectors depend on it.
> 

By that I mean the *shared* building block styles.

	Pavel Ivanov [:ivanovpavel][:pivanov] UX Assignee
	Comment 12 • 11 years ago

Hey Eitan,
I agree with you :)

Hey Kaze,
We will try to land most of the patches asap.

	Pavel Ivanov [:ivanovpavel][:pivanov] UX Assignee
	Comment 13 • 11 years ago

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/7672d23a6d107c7ca660f702725438aa35c0d554