Closed
Bug 947104
Opened 11 years ago
Closed 11 years ago
[Music] Update to new 1.3 tab bar visual design
Categories
(Firefox OS Graveyard :: Gaia::Music, defect)
Tracking
(b2g-v1.2 unaffected, b2g-v1.3 affected, b2g-v1.4 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
b2g-v1.2 | --- | unaffected |
b2g-v1.3 | --- | affected |
b2g-v1.4 | --- | fixed |
People
(Reporter: epang, Assigned: pivanov)
References
Details
(Whiteboard: ux-tracking, visual design, visual-tracking, bokken)
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
text/x-github-pull-request
|
squib
:
review+
nhirata
:
approval-gaia-v1.3-
|
Details |
Update to the new 1.3 tab bar visual design.
Assignee | ||
Comment 1•11 years ago
|
||
Comment 2•11 years ago
|
||
Pavel, I should review this one instead of bug 940520, right?
Flags: needinfo?(pivanov)
Assignee | ||
Updated•11 years ago
|
Attachment #8343607 -
Flags: review?(dflanagan)
Comment 3•11 years ago
|
||
Comment on attachment 8343607 [details]
patch for Gaia/master
Pavel,
I'm not the right person to review this Music app change.
Dominic or Jim, could you review this please?
The visual design team would like to get this patch into 1.3 I think.
Attachment #8343607 -
Flags: review?(squibblyflabbetydoo)
Attachment #8343607 -
Flags: review?(dkuo)
Attachment #8343607 -
Flags: review?(dflanagan)
Reporter | ||
Comment 4•11 years ago
|
||
Hey Jim & Dominic, as i noted in other bugs. The patch from this bug is dependent with the patch from https://bugzilla.mozilla.org/show_bug.cgi?id=947093
They will land together along with all other toolbar updates to remain consistent. Thanks!
Flags: needinfo?(squibblyflabbetydoo)
Comment 5•11 years ago
|
||
Comment on attachment 8343607 [details]
patch for Gaia/master
This all looks reasonable. rs=me!
Attachment #8343607 -
Flags: review?(squibblyflabbetydoo)
Attachment #8343607 -
Flags: review?(dkuo)
Attachment #8343607 -
Flags: review+
Updated•11 years ago
|
Flags: needinfo?(squibblyflabbetydoo)
Reporter | ||
Comment 6•11 years ago
|
||
(In reply to Jim Porter (:squib) from comment #5)
> Comment on attachment 8343607 [details]
> patch for Gaia/master
>
> This all looks reasonable. rs=me!
thanks Jim!
Reporter | ||
Updated•11 years ago
|
Whiteboard: ux-tracking, visual design, visual-tracking, jian → ux-tracking, visual design, visual-tracking, bokken
Assignee | ||
Comment 7•11 years ago
|
||
Landed to master:
https://github.com/mozilla-b2g/gaia/commit/6228f439a45b0f421addb44f181d42ead771c45d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
blocking-b2g: --- → 1.3?
status-b2g-v1.2:
--- → unaffected
status-b2g-v1.3:
--- → affected
status-b2g-v1.4:
--- → fixed
Comment on attachment 8343607 [details]
patch for Gaia/master
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:
Attachment #8343607 -
Flags: approval-gaia-v1.3?
Needs approval. Could we get approval please?
Flags: needinfo?(praghunath)
Updated•11 years ago
|
blocking-b2g: 1.3? → ---
Comment 10•11 years ago
|
||
Comment on attachment 8343607 [details]
patch for Gaia/master
approved for gaia 1.3 per triage
Attachment #8343607 -
Flags: approval-gaia-v1.3? → approval-gaia-v1.3+
Flags: needinfo?(praghunath)
Comment on attachment 8343607 [details]
patch for Gaia/master
we are no longer taking the change in 1.3; we will be landing the tab change in 1.4
Attachment #8343607 -
Flags: approval-gaia-v1.3+ → approval-gaia-v1.3-
Flags: in-moztrap+
You need to log in
before you can comment on or make changes to this bug.
Description
•