Closed Bug 949980 Opened 11 years ago Closed 10 years ago

[Gaia][DSDS] Fine tune signal strength bar and call forwarding visuals

Categories

(Firefox OS Graveyard :: Gaia, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(tracking-b2g:backlog)

RESOLVED DUPLICATE of bug 1056969
tracking-b2g backlog

People

(Reporter: arthurcc, Assigned: mikehenrty)

References

Details

(Whiteboard: [systemsfe][p=3][priority])

Attachments

(6 files)

Attached file DSDS Status Bar visuals (deleted) —
The visual style should follow the spec.
Assignee: nobody → arthur.chen
(In reply to Arthur Chen [:arthurcc] from comment #0) > Created attachment 8347150 [details] > DSDS Status Bar visuals > > The visual style should follow the spec. Arthur, is there any icon for this ? Can't find them in the zip.
There is no new icon added. It is just layout and color issue.
Summary: [Gaia][DSDS] Fine tune signal strength bar visuals → [Gaia][DSDS] Fine tune signal strength bar and call forwarding visuals
Please refer to bug 949978 for visual design. Thanks.
I don't think we need it to block the user story. The feature is done and just need a little modification. Still nominate it as v1.4+ because it worth. :p
No longer blocks: 949978
blocking-b2g: --- → 1.4?
Oops. my bad, I thought bug 949978 was the original user story. put the blocker back.
Blocks: 949978
Moving to backlog for later release
blocking-b2g: 1.4? → backlog
Attached file DSDS status bar visual spec .pdf (deleted) —
Hi Arthur, I've updated all the scenario for DSDS status bar in this visual spec, Thanks!
Depends on: 975973
No longer depends on: 975973
Stealing this bug, since I have a WIP from bug 975973.
Assignee: arthur.chen → mhenretty
Whiteboard: [systemsfe][p=3]
Attached file Github PR (deleted) —
Arthur, I hope you don't mind that I stole this from you. Would you take a look here?
Attachment #8397395 - Flags: review?(arthur.chen)
Thank you for taking care of this as currently I don't have time working on it. :)
Attached image gap1.png (deleted) —
Attached image gap2.png (deleted) —
Comment on attachment 8397395 [details] Github PR There are gaps as the attachments shown after enabling data connection and setting the primary sim of data call to the second one.
Attachment #8397395 - Flags: review?(arthur.chen)
Thanks for the quick review. So there are two gaps I see in your attachment. One is a gap between the call forwarding icon and the data signal icons. I have fixed that in the PR. I added it as a separate commit, so you can see the interdiff, but I will of course squash before anything is merged. The second gap is the one where the connection type ('E', or '3G' for example) should be. It seems that even if no connection type is displayed, it still takes up space on the statusbar. The problem is, I cannot reproduce this locally. I've tried setting default SIM to 2, enabling disabling all data connections, enabling disabling wifi, and even hacking statusbar.js to explicitly set connection type. Can you provide me with some more steps to reproduce what you are seeing?
Attached image feedback.png (deleted) —
Hi Fang, how is this looking? Any tweaks?
Attachment #8398246 - Flags: ui-review?(fshih)
Sorry, meant to ni? Aurthur on comment 14.
Flags: needinfo?(arthur.chen)
Target Milestone: --- → 1.4 S4 (28mar)
Comment on attachment 8398246 [details] feedback.png Hi Michael, Thanks for the updates, they look great! This is very close!! I'm just wondering is the font weight of the SIM number are medium? They seem a little thin on my device. Or maybe is a screen capture problem? The other one is if that’s possible can we move the call forwarding icon 3px closer to the right? Cause they (SIM number 1, call forwarding icon and number 2) seem a little apart from each other. Thanks!!!
I may place the images in a wrong order. My steps were: 1. Set the primary sim to sim 1. 2. Enable data connection and wait for the data call established. 3. Switch the primary sim to sim 2. --> (gap2.png) 4. Wait for the data call established. 5. Disable data connection. --> (gap1.png)
Flags: needinfo?(arthur.chen)
Whiteboard: [systemsfe][p=3] → [systemsfe][p=3][priority]
Target Milestone: 1.4 S4 (28mar) → 1.4 S5 (11apr)
Target Milestone: 1.4 S5 (11apr) → 1.4 S6 (25apr)
Target Milestone: 1.4 S6 (25apr) → 2.0 S1 (9may)
Target Milestone: 2.0 S1 (9may) → 2.0 S2 (23may)
Target Milestone: 2.0 S2 (23may) → 2.0 S3 (6june)
Target Milestone: 2.0 S3 (6june) → 2.0 S4 (20june)
Target Milestone: 2.0 S4 (20june) → ---
Attachment #8398246 - Flags: ui-review?(fshih) → ui-review+
All the work for signal strength was done in bug 1056969.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: