Closed
Bug 949980
Opened 11 years ago
Closed 10 years ago
[Gaia][DSDS] Fine tune signal strength bar and call forwarding visuals
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(tracking-b2g:backlog)
RESOLVED
DUPLICATE
of bug 1056969
tracking-b2g | backlog |
People
(Reporter: arthurcc, Assigned: mikehenrty)
References
Details
(Whiteboard: [systemsfe][p=3][priority])
Attachments
(6 files)
The visual style should follow the spec.
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → arthur.chen
Comment 1•11 years ago
|
||
(In reply to Arthur Chen [:arthurcc] from comment #0)
> Created attachment 8347150 [details]
> DSDS Status Bar visuals
>
> The visual style should follow the spec.
Arthur, is there any icon for this ? Can't find them in the zip.
Reporter | ||
Comment 2•11 years ago
|
||
There is no new icon added. It is just layout and color issue.
Reporter | ||
Updated•11 years ago
|
Summary: [Gaia][DSDS] Fine tune signal strength bar visuals → [Gaia][DSDS] Fine tune signal strength bar and call forwarding visuals
Comment 3•11 years ago
|
||
Please refer to bug 949978 for visual design. Thanks.
Comment 4•11 years ago
|
||
I don't think we need it to block the user story. The feature is done and just need a little modification. Still nominate it as v1.4+ because it worth. :p
No longer blocks: 949978
blocking-b2g: --- → 1.4?
Comment 5•11 years ago
|
||
Oops. my bad, I thought bug 949978 was the original user story. put the blocker back.
Blocks: 949978
Comment 7•11 years ago
|
||
Hi Arthur, I've updated all the scenario for DSDS status bar in this visual spec, Thanks!
Assignee | ||
Comment 8•11 years ago
|
||
Stealing this bug, since I have a WIP from bug 975973.
Assignee: arthur.chen → mhenretty
Whiteboard: [systemsfe][p=3]
Assignee | ||
Comment 9•11 years ago
|
||
Arthur, I hope you don't mind that I stole this from you. Would you take a look here?
Attachment #8397395 -
Flags: review?(arthur.chen)
Reporter | ||
Comment 10•11 years ago
|
||
Thank you for taking care of this as currently I don't have time working on it. :)
Reporter | ||
Comment 11•11 years ago
|
||
Reporter | ||
Comment 12•11 years ago
|
||
Reporter | ||
Comment 13•11 years ago
|
||
Comment on attachment 8397395 [details]
Github PR
There are gaps as the attachments shown after enabling data connection and setting the primary sim of data call to the second one.
Attachment #8397395 -
Flags: review?(arthur.chen)
Assignee | ||
Comment 14•11 years ago
|
||
Thanks for the quick review.
So there are two gaps I see in your attachment. One is a gap between the call forwarding icon and the data signal icons. I have fixed that in the PR. I added it as a separate commit, so you can see the interdiff, but I will of course squash before anything is merged.
The second gap is the one where the connection type ('E', or '3G' for example) should be. It seems that even if no connection type is displayed, it still takes up space on the statusbar. The problem is, I cannot reproduce this locally. I've tried setting default SIM to 2, enabling disabling all data connections, enabling disabling wifi, and even hacking statusbar.js to explicitly set connection type. Can you provide me with some more steps to reproduce what you are seeing?
Assignee | ||
Comment 15•11 years ago
|
||
Hi Fang, how is this looking? Any tweaks?
Attachment #8398246 -
Flags: ui-review?(fshih)
Assignee | ||
Comment 16•11 years ago
|
||
Sorry, meant to ni? Aurthur on comment 14.
Flags: needinfo?(arthur.chen)
Assignee | ||
Updated•11 years ago
|
Target Milestone: --- → 1.4 S4 (28mar)
Comment 17•11 years ago
|
||
Comment on attachment 8398246 [details]
feedback.png
Hi Michael, Thanks for the updates, they look great! This is very close!!
I'm just wondering is the font weight of the SIM number are medium? They seem a little thin on my device. Or maybe is a screen capture problem?
The other one is if that’s possible can we move the call forwarding icon 3px closer to the right? Cause they (SIM number 1, call forwarding icon and number 2) seem a little apart from each other. Thanks!!!
Reporter | ||
Comment 18•11 years ago
|
||
I may place the images in a wrong order.
My steps were:
1. Set the primary sim to sim 1.
2. Enable data connection and wait for the data call established.
3. Switch the primary sim to sim 2. --> (gap2.png)
4. Wait for the data call established.
5. Disable data connection. --> (gap1.png)
Flags: needinfo?(arthur.chen)
Updated•11 years ago
|
Whiteboard: [systemsfe][p=3] → [systemsfe][p=3][priority]
Updated•11 years ago
|
Target Milestone: 1.4 S4 (28mar) → 1.4 S5 (11apr)
Updated•11 years ago
|
Target Milestone: 1.4 S5 (11apr) → 1.4 S6 (25apr)
Updated•11 years ago
|
Target Milestone: 1.4 S6 (25apr) → 2.0 S1 (9may)
Updated•11 years ago
|
Target Milestone: 2.0 S1 (9may) → 2.0 S2 (23may)
Updated•11 years ago
|
Target Milestone: 2.0 S2 (23may) → 2.0 S3 (6june)
Updated•10 years ago
|
Target Milestone: 2.0 S3 (6june) → 2.0 S4 (20june)
Updated•10 years ago
|
Target Milestone: 2.0 S4 (20june) → ---
Updated•10 years ago
|
Attachment #8398246 -
Flags: ui-review?(fshih) → ui-review+
Assignee | ||
Comment 19•10 years ago
|
||
All the work for signal strength was done in bug 1056969.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•