Julien Wajsberg [:julienw] Reporter
	Description • 11 years ago

All network type icons are smaller on a DSDS device because we need space for the "1" and "2" indicators. But the "data circle" icon is not smaller and so overload the "1" and "2" indicators.

See attachment.

	Francis Djabri [:djabber]
	Comment 2 • 11 years ago

Hi Eric, looks like we need a new icon for the data circle in DSDS configurations. Check out the DSDS spec at: https://mozilla.box.com/s/9dm27fcwtypeamgu09y0, page 5. Data indicators like 3G, Edge and 2G need to fit above the "1" and "2".

	Carrie Wang [New account: carrie75521@gmail.com]
	Comment 3 • 11 years ago

Hi Julien, 

This is only the interaction spec. VxD did the final icon design on these data indication in 1.3.
ni? Fang to provide the visual spec here.
Thanks!

	Fang Shih [:fang]
	Comment 4 • 11 years ago

Attached is the final visual spec. Thanks!

	Julien Wajsberg [:julienw] Reporter
	Comment 6 • 11 years ago

Oh, too bad, I really enjoyed the small 3G, E, etc icons as shown in attachment 8380527 [details] :( The new visual design spec looks more cluttered...

	Gregor Wagner [:gwagner]
	Comment 7 • 11 years ago

Sam, do you have a dual sim device?

	Sam Joch [:samjoch]
	Comment 8 • 11 years ago

Nop dont have one.

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 9 • 11 years ago

(In reply to Fang Shih from comment #5)
> Created attachment 8381868 [details]
> DSDS-20131125.pdf

Hi Fang, I have a question about the position of the SIM number over the signal strength indicator. Right now, if we are data roaming we place a small triangle above the signal strength indicator. However, this conflicts with the position of the SIM number (they will overlap). So what do we do in the case of data roaming?

Let me know if you want a screenshot of the data roaming scenario.

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 10 • 11 years ago

Also, Fang do you know the bug where this spec was supposed to be implemented, because it seems like bug 921389 landed before this spec was complete. Also, was there a UI review for this spec?

	Fang Shih [:fang]
	Comment 11 • 11 years ago

Hi Michael, I wasn't involved in bug 921389, that was done by developers to complete the function only. Currently, all the visual related to DSDS status bar are working on bug 949980. I will publish the spec for data roaming scenario here as well. Thanks!

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 12 • 11 years ago

Looks like I'm implementing the visual refresh for the dsds signal strength in this bug, so I will make the visual refresh bugs dependents.

	Julien Wajsberg [:julienw] Reporter
	Comment 13 • 11 years ago

Actually Michael, since it's 1.4+, I don't think you should do the Visual Refresh due for v1.5 here ;)

I think a 1.4 specific patch is enough here. The difficult thing to know is: what should be done?

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 14 • 11 years ago

(In reply to Julien Wajsberg [:julienw] (away until March 24) from comment #13)
> Actually Michael, since it's 1.4+, I don't think you should do the Visual
> Refresh due for v1.5 here ;)
> 
> I think a 1.4 specific patch is enough here. The difficult thing to know is:
> what should be done?

Well the easiest and probably most appropriate thing would be to make the circle small and move it above the SIM number, just like the `E` in attachment 8380527 [details]. Let's see if UX is ok with this for 1.4.

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 15 • 11 years ago

Hi Fang, since the signal bar visual refresh has been moved to 1.5, how do you feel about doing a 1.4 fix specifically for this data-circle bug? The attachment shows what that will look like, and I will attach a PR for it shortly. Is this acceptable for a 1.4 fix?

	Fang Shih [:fang]
	Comment 17 • 11 years ago

Comment on attachment 8396666 [details]
Data Circle above SIM number

Hi Michael, 
Thanks for the update. After I've discussed with UX designer. We still hope the o and E can stay next to the SIM number like where 3G was located (also no scale down the size), since they are all represent data connection. Thanks!

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 18 • 11 years ago

Fang,

The scope of this bug is the "data circle" icon being in a strange place for DSDS. Currently the connection type in 1.4 (whether it is '3G', 'E', 'H', 'H+', etc.) is displayed above the SIM number (as shown in attachment 8380527 [details]). To fix this data circle problem, you pointed me at the visual spec in bug 949980 (attachment 8395499 [details]). However, that spec involves moving the data connection type and tweaking call forwarding, and it is out of scope for this bug. Also importantly, it was deemed not a blocker for 1.4 (see bug 949980 comment 6), while this bug is a blocker.

I do think the updated spec is good, and will submit a PR later for bug 949980 and try to get it pushed through for 1.4. But since it involves moving things around it might be deemed too risky for 1.4, and so in the meantime we need a 1.4 specific fix for the data circle scenario that fits with what we currently have in 1.4. I suggest that attachment 8396666 [details] is consistent, but in any case we need a "data circle" specific fix here. Please let me know what we should do about the data circle problem (attachment 8380518 [details]) in 1.4.

	Fang Shih [:fang]
	Comment 19 • 11 years ago

Michael, 
I agree with you on this. We keep the data circle on top in 1.4. And try to get the updated spec pushed in bug 949980.  Thanks for the updated!

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 20 • 11 years ago

Thanks Fang!

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 21 • 11 years ago

Comment on attachment 8396671 [details]
Github PR, data circle above SIM number

Arthur, would you mind reviewing this interim 1.4 statusbar fix?

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 22 • 11 years ago

Review ping

	Arthur Chen [:arthurcc][inactive after 6/30]
	Comment 23 • 11 years ago

Comment on attachment 8396671 [details]
Github PR, data circle above SIM number

f=me. Flagging the owner of the system app.

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 24 • 11 years ago

Review ping.

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 25 • 11 years ago

Comment on attachment 8396671 [details]
Github PR, data circle above SIM number

[Approval Request Comment]
This is a style fix to the statusbar for when the SIM goes out of data covereage.

[Bug caused by] (feature/regressing bug #):
bug 921389

[User impact] if declined:
Status bar looks pretty bad, see first attachment.

[Testing completed]:
On device testing (fugu).

[Risk to taking this patch] (and alternatives if risky):
The patch is pretty isolated to the data circle icon, which couldn't be much worse.

[String changes made]: none.

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 26 • 11 years ago

master: https://github.com/mozilla-b2g/gaia/commit/4b6044162277ae481d26244e7441c0a16dc63e01

v1.4: https://github.com/mozilla-b2g/gaia/commit/61c502c5f8645af76d485bd8e85c51f792d1cbe7

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 27 • 11 years ago

No tests for this stylistic change.