Closed
Bug 951978
(secure-window)
Opened 11 years ago
Closed 11 years ago
[Window Management] Implement Secure Window (for Secure Camera App on Lockscreen)
Categories
(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alive, Assigned: gweng)
References
Details
Attachments
(1 file)
|
Reporter | |
Updated•11 years ago
|
Assignee: nobody → alive
|
|
Reporter | |
Updated•11 years ago
|
Summary: [Window Management] Implement Secure Window → [Window Management] Implement Secure Window (for Secure Camera App on Lockscreen)
|
|
Reporter | |
Updated•11 years ago
|
Alias: secure-window
|
||
Comment 1•11 years ago
|
||
How about call it guest window? It behaves like guest mode in browser
https://wiki.mozilla.org/Mobile/Projects/Guest_browsing
|
|
Reporter | |
Comment 2•11 years ago
|
||
The goal of this new window:
* Layering: Could be opened on Lockscreen
* Reusable: Could be used by System app to do
new SecureWindow(url); // The url here is relative path.
* Different transition style from opening normal app: should use existing 'slideleft'/'slideright' animation.
|
|
Reporter | |
Comment 3•11 years ago
|
||
We may not have SecureWindowFactory (before Lockscreen is an app) but we need SecureWindowManager to manage secure window instances.
|
||
Comment 4•11 years ago
|
||
Greg, you are working on this right?
Assignee: alive → gweng
Flags: needinfo?(gweng)
|
Assignee | |
Updated•11 years ago
|
Blocks: lockscreen-refactor
|
|
Assignee | |
Comment 6•11 years ago
|
||
Created:
1. SecureWindow: inherits the AppWindow with some modifications fit its unique styles
2. SecureWindowManager: subset of AppWindowManager; would handle only those cases would happen in the secure mode
3. SecureWindowFactory: to prevent other components directly hold secure apps
Attachment #8362415 -
Flags: review?(alive)
|
|
Assignee | |
Comment 7•11 years ago
|
||
Travis was green: https://travis-ci.org/mozilla-b2g/gaia/builds/17326089
|
|
Assignee | |
Updated•11 years ago
|
Blocks: alt-camera-helper
|
|
Assignee | |
Updated•11 years ago
|
Blocks: camera-helper
|
|
Assignee | |
Updated•11 years ago
|
Blocks: clock-helper
|
|
Assignee | |
Updated•11 years ago
|
Blocks: emergencypad-helper
|
|
Assignee | |
Updated•11 years ago
|
Blocks: passcodepad-helper
|
|
Reporter | |
Comment 8•11 years ago
|
||
Comment on attachment 8362415 [details]
Patch
Well done,
but please see github comments.
If you feel that you need to let me review again please do.
Attachment #8362415 -
Flags: review?(alive) → review+
|
|
Assignee | |
Updated•11 years ago
|
Blocks: unlocker-helper
|
|
Assignee | |
Updated•11 years ago
|
No longer blocks: unlocker-helper
|
|
Assignee | |
Updated•11 years ago
|
No longer blocks: clock-helper
|
|
Assignee | |
Updated•11 years ago
|
No longer blocks: passcodepad-helper
|
|
Assignee | |
Comment 9•11 years ago
|
||
Comment on attachment 8362415 [details]
Patch
Set review again because of some modifications concern other components.
Travis was green: https://travis-ci.org/mozilla-b2g/gaia/builds/17453277
Attachment #8362415 -
Flags: review+ → review?(alive)
|
|
Reporter | |
Comment 10•11 years ago
|
||
Comment on attachment 8362415 [details]
Patch
Some little stuff needs to be addressed.
Attachment #8362415 -
Flags: review?(alive)
|
|
Assignee | |
Comment 11•11 years ago
|
||
Comment on attachment 8362415 [details]
Patch
After fixed stuff that Alive mentioned and take out a failed test because of Bug 964117, Travis is green now: https://travis-ci.org/mozilla-b2g/gaia/builds/17738178
Attachment #8362415 -
Flags: review?(alive)
|
|
Reporter | |
Comment 12•11 years ago
|
||
Comment on attachment 8362415 [details]
Patch
Please see github.
Attachment #8362415 -
Flags: review?(alive) → review+
|
|
Assignee | |
Comment 13•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•