Closed
Bug 960381
(lockscreen-refactor)
Opened 11 years ago
Closed 7 years ago
[LockScreen] Refactor the lockscreen.js
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: gweng, Unassigned)
References
Details
Current LockScreen carries too much historical code, like:
1. IFRAME embedded camera/emergency panel
2. No clear animation controller
3. No clear states between panels switching
4. No clear way to plugin/unplugin different widgets and panels on the LockScreen. They now are all "hardcode" inside the LockScreen, except the sliding strategy which I had pulled out
Since I'm trying to solve 1. with SecureWindow and SecureWindowManager, the animation problem become more tricky. Because the original animation controller is scattered about CSS, "data-panel" attribute, and functions like unload panel and load panel.
I think we should invent a way to describe the animation and states changing process more clearly first, and then modularize the different components on the LockScreen, especially describe how them can be enable/disable and managed inside LockScreen. This should be a prerequisite of making LockScreen as an app.
I would not do all of these in this bug. I may fire other bugs to refactor it once a part.
Reporter | ||
Comment 1•11 years ago
|
||
NI Tim to discuss about priority. If there're other emergency things should be done, I would postpone this bug.
Flags: needinfo?(timdream)
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → gweng
Updated•11 years ago
|
Component: Gaia::System → Gaia::System::Lockscreen
Reporter | ||
Updated•11 years ago
|
Blocks: lockscreen-as-app
Reporter | ||
Comment 3•11 years ago
|
||
I would start to solve this bugs (and fire sub-bugs) after I finished the Bug 951978.
Reporter | ||
Updated•11 years ago
|
Depends on: secure-window
Reporter | ||
Updated•11 years ago
|
Depends on: lockscreen-instance
Reporter | ||
Updated•11 years ago
|
Alias: lockscreen-refactor
Reporter | ||
Updated•11 years ago
|
Blocks: lockscreen-amd
Reporter | ||
Updated•11 years ago
|
No longer blocks: lockscreen-amd
Depends on: lockscreen-amd
Reporter | ||
Updated•11 years ago
|
Depends on: emergencycall-as-app
Reporter | ||
Updated•11 years ago
|
Depends on: alt-camera-helper
Reporter | ||
Updated•11 years ago
|
Depends on: camera-helper
Reporter | ||
Updated•11 years ago
|
Depends on: clock-helper
Reporter | ||
Updated•11 years ago
|
Depends on: emergencypad-helper
Reporter | ||
Updated•11 years ago
|
Depends on: passcodepad-helper
Reporter | ||
Updated•11 years ago
|
Depends on: unlocker-helper
Reporter | ||
Updated•11 years ago
|
Depends on: conninfo-widget
Reporter | ||
Updated•11 years ago
|
Depends on: screenoff-helper
Reporter | ||
Updated•11 years ago
|
Depends on: panel-mediator
Reporter | ||
Updated•11 years ago
|
Depends on: notification-helper
Reporter | ||
Updated•11 years ago
|
Depends on: lockscreen-widgets
Reporter | ||
Updated•11 years ago
|
No longer blocks: lockscreen-as-app
Depends on: lockscreen-as-app
Reporter | ||
Updated•8 years ago
|
Assignee: gweng → nobody
Comment 4•7 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•