Mike Hommey [:glandium] Assignee
	Description • 11 years ago

      No description provided.

	Gregory Szorc [:gps]
	Comment 5 • 11 years ago

Comment on attachment 8360290 [details] [diff] [review]
Recurse icu from top-level when building js

Review of attachment 8360290 [details] [diff] [review]:
-----------------------------------------------------------------

This should be a nice speed win!

I didn't do a super thorough job verifying the new Makefile.in matches the old content. Looks pretty similar and I trust you'd tell me if other changes were sneaking in here.

::: intl/icu/Makefile.in
@@ +74,5 @@
> +distclean clean::
> +ifdef CROSS_COMPILE
> +	$(call SUBMAKE,$@,host)
> +endif
> +	$(call SUBMAKE,$@,target)

I guess we're lucky and don't hit any order-only prerequisites in the clean targets (since we're not using $(ICU_MAKE) here).

	Mike Hommey [:glandium] Assignee
	Comment 6 • 11 years ago

(In reply to Gregory Szorc [:gps] from comment #5)
> Comment on attachment 8360290 [details] [diff] [review]
> Recurse icu from top-level when building js
> 
> Review of attachment 8360290 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This should be a nice speed win!
> 
> I didn't do a super thorough job verifying the new Makefile.in matches the
> old content. Looks pretty similar and I trust you'd tell me if other changes
> were sneaking in here.

There is one change to make it a static directory (in that there's now only one rule to build stuff, instead of choosing between compile and libs depending on MOZ_PSEUDO_DERECURSE)

> ::: intl/icu/Makefile.in
> @@ +74,5 @@
> > +distclean clean::
> > +ifdef CROSS_COMPILE
> > +	$(call SUBMAKE,$@,host)
> > +endif
> > +	$(call SUBMAKE,$@,target)
> 
> I guess we're lucky and don't hit any order-only prerequisites in the clean
> targets (since we're not using $(ICU_MAKE) here).

Actually, iirc, pymake will barf if a makefile contains an order-only prereq at parse time, so we may actually hit this already. But since barely anyone runs make clean... want me to change this while here?

	Gregory Szorc [:gps]
	Comment 7 • 11 years ago

Please change SUBMAKE to ICU_MAKE. carry r+ forward.

	Mike Hommey [:glandium] Assignee
	Comment 8 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/17c463691232
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8356a0b4158
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7a650bc263c
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d19bc17175c

	Carsten Book [:Tomcat]
	Comment 9 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/17c463691232
https://hg.mozilla.org/mozilla-central/rev/c8356a0b4158
https://hg.mozilla.org/mozilla-central/rev/f7a650bc263c
https://hg.mozilla.org/mozilla-central/rev/5d19bc17175c