Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now) Reporter
	Description • 11 years ago

I'm unable to compile js shells on Windows - I think it used to work at the start of the year.

Steps:
1. In js/src, run autoconf-2.13
2. Create and cd into objdir
3. Run: MAKE=mozmake AR=ar sh ../configure --enable-optimize --enable-debug --enable-profiling --enable-gczeal --enable-debug-symbols --enable-methodjit --enable-type-inferenc
e --disable-tests --enable-more-deterministic --enable-exact-rooting --disable-threadsafe
4. Run: mozmake -j10 -s

	Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now) Reporter
	Comment 1 • 11 years ago

Tested on mozilla-central 802d87c77e76 and on MozillaBuild 1.9.0 test build.

	Mike Hommey [:glandium] Assignee
	Comment 2 • 11 years ago

Please attach a log without -s.

	Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now) Reporter
	Comment 3 • 11 years ago

-j1 build log

	Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now) Reporter
	Comment 4 • 11 years ago

I was also using MSVC 2010.

	Mike Hommey [:glandium] Assignee
	Comment 6 • 11 years ago

Comment on attachment 8374670 [details] [diff] [review]
Define IMPL_MFBT when building standalone js

Gary, can you try this patch?

	Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now) Reporter
	Comment 7 • 11 years ago

Comment on attachment 8374670 [details] [diff] [review]
Define IMPL_MFBT when building standalone js

feedback+ because this seems to be able to fix non-threadsafe 32-bit builds on Windows. \o/

	Mike Hommey [:glandium] Assignee
	Comment 8 • 11 years ago

Comment on attachment 8374670 [details] [diff] [review]
Define IMPL_MFBT when building standalone js

js/src/moz.build, before bug 958404, included mfbt/common.mozbuild, which did define IMPL_MFBT.

	Mike Hommey [:glandium] Assignee
	Comment 9 • 11 years ago

Note, if you want to avoid js standalone builds being broken by build system changes, you should get them running on automation. I can't guarantee that other upcoming changes are not going to break you again.

	Mike Hommey [:glandium] Assignee
	Comment 10 • 11 years ago

(And as this bug shows, the current coverage of these builds on linux is insufficient to catch all the problems)

	Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now) Reporter
	Comment 11 • 11 years ago

(In reply to Mike Hommey [:glandium] from comment #9)
> Note, if you want to avoid js standalone builds being broken by build system
> changes, you should get them running on automation. I can't guarantee that
> other upcoming changes are not going to break you again.

I filed bug 972089. Apparently bug 785798 removed them in the past.

	Mike Hommey [:glandium] Assignee
	Comment 12 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/f76b7bc18dbc

	Ryan VanderMeulen [:RyanVM]
	Comment 13 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/f76b7bc18dbc

	Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now) Reporter
	Comment 14 • 11 years ago

I've verified that this works now for m-c, and should be backported to aurora too. (will need nomination for approval flag)

	Ryan VanderMeulen [:RyanVM]
	Comment 15 • 11 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/fe15cb97d779

	Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now) Reporter
	Comment 16 • 10 years ago

(In reply to Gary Kwong [:gkw] [:nth10sd] from comment #0)
> Steps:
> ...
> 4. Run: mozmake -j10 -s

ehoogeveen pointed to me over IRC that this step may have needed the environment as well:

MAKE=mozmake mozmake -j10 -s