Closed
Bug 958773
Opened 11 years ago
Closed 11 years ago
Don't use js-ctypes in the ril worker
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(blocking-b2g:1.3T+, b2g-v1.3T fixed)
| Tracking | Status | |
|---|---|---|
| b2g-v1.3T | --- | fixed |
People
(Reporter: fabrice, Assigned: fabrice)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
vicamo
:
review+
|
Details | Diff | Splinter Review |
We're using a lot of memory just to get a few properties.
|
Assignee | |
Comment 1•11 years ago
|
||
Instead I pass the values to the worker in the 'setInitialOptions' command.
I can't run get_about_memory.py right now on my build but I've hit a all time low in b2g RSS with this patch so there's hope it actually helps. If someone could run a real memory report that would be great!
Assignee: nobody → fabrice
Attachment #8358712 -
Flags: review?(vyang)
|
||
Updated•11 years ago
|
Attachment #8358712 -
Flags: review?(vyang) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
Whiteboard: [tarako][POVB]
|
||
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C2/1.4 S2(17jan)
|
|
||
Comment 4•11 years ago
|
||
I/Gecko ( 45): RIL Worker[0]: Parcel handling threw ReferenceError: netHelpers is not defined
I/Gecko ( 45): readDataCall_v6@resource://gre/modules/ril_worker.js:5836
I/Gecko ( 45): RIL[REQUEST_DATA_CALL_LIST]@resource://gre/modules/ril_worker.js:5866
I/Gecko ( 45): RIL[REQUEST_SETUP_DATA_CALL]@resource://gre/modules/ril_worker.js:5314
I/Gecko ( 45): RIL.handleParcel@resource://gre/modules/ril_worker.js:4949
I/Gecko ( 45): Buf.processParcel@resource://gre/modules/ril_worker.js:152
I/Gecko ( 45): require._tmpModules[":resource://gre/modules/workers/worker_buf.js"]/Buf.processIncoming@blob:78893422-8293-41e8-b462-fa4e991e9b71:536
I/Gecko ( 45): onRILMessage@resource://gre/modules/ril_worker.js:13910
|
||
Comment 5•11 years ago
|
||
Backed out for:
https://tbpl.mozilla.org/php/getParsedLog.php?id=32939405&tree=B2g-Inbound
https://hg.mozilla.org/mozilla-central/rev/654854b387dd
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 6•11 years ago
|
||
Re-land with no change: https://hg.mozilla.org/integration/b2g-inbound/rev/2aa44fe4b007
Fix is in: https://hg.mozilla.org/integration/b2g-inbound/rev/51f5ff2e6667
|
||
Comment 7•11 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
|
||
Comment 8•11 years ago
|
||
Note - either this bug or bug 934125 broke cell data. See bug 959602.
|
||
Comment 9•11 years ago
|
||
triage: 1.3T+ for tarako
blocking-b2g: --- → 1.3T+
Whiteboard: [tarako][POVB]
|
|
Assignee | |
Comment 10•11 years ago
|
||
status-b2g-v1.3T:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•