Closed Bug 959503 Opened 11 years ago Closed 11 years ago

B2G RIL: Parcel handling threw ReferenceError: netHelpers is not defined

Categories

(Firefox OS Graveyard :: RIL, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:1.3T+, b2g-v1.3 unaffected, b2g-v1.3T fixed, b2g-v1.4 fixed)

RESOLVED FIXED
blocking-b2g 1.3T+
Tracking Status
b2g-v1.3 --- unaffected
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed

People

(Reporter: vicamo, Assigned: vicamo)

References

Details

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #958773 +++ I/Gecko ( 45): RIL Worker[0]: Parcel handling threw ReferenceError: netHelpers is not defined I/Gecko ( 45): readDataCall_v6@resource://gre/modules/ril_worker.js:5836 I/Gecko ( 45): RIL[REQUEST_DATA_CALL_LIST]@resource://gre/modules/ril_worker.js:5866 I/Gecko ( 45): RIL[REQUEST_SETUP_DATA_CALL]@resource://gre/modules/ril_worker.js:5314 I/Gecko ( 45): RIL.handleParcel@resource://gre/modules/ril_worker.js:4949 I/Gecko ( 45): Buf.processParcel@resource://gre/modules/ril_worker.js:152 I/Gecko ( 45): require._tmpModules[":resource://gre/modules/workers/worker_buf.js"]/Buf.processIncoming@blob:78893422-8293-41e8-b462-fa4e991e9b71:536 I/Gecko ( 45): onRILMessage@resource://gre/modules/ril_worker.js:13910
Summary: Don't use js-ctypes in the ril worker → B2G RIL: Parcel handling threw ReferenceError: netHelpers is not defined
Attached patch patch (deleted) — Splinter Review
All of `options.ip`, `options.mask` and `options.broadcast` are only referenced in RadioInterfaceLayer or above and are never referenced in ril_worker. Moving these assignments to prevent from loading "systemlibs.js" again, which was removed in bug 958773 to save memory.
Attachment #8359648 - Flags: review?(htsai)
Comment on attachment 8359648 [details] [diff] [review] patch Review of attachment 8359648 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8359648 - Flags: review?(htsai) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Blocks: 960894
Hi Vicamo, is this needed for 1.3? or even tarako? thanks
Flags: needinfo?(vyang)
(In reply to Joe Cheng [:jcheng] from comment #8) > Hi Vicamo, is this needed for 1.3? or even tarako? thanks Where ever the patch in bug 958773 is landed, the patch here MUST come after. v1.3 => not needed, but v1.3t => needed. I'll uplift this to v1.3t.
Flags: needinfo?(vyang)
blocking-b2g: --- → 1.3T?
Attached patch [v1.3t] patch (deleted) — Splinter Review
mark 1.3T?, remove [tarako] whiteboard
Whiteboard: [tarako][POVB] → [POVB]
Attachment #8373157 - Flags: feedback?(vliu)
does not seem like [POVB], remove [POVB] whiteboard
Whiteboard: [POVB]
triage: need this for tarako 1.3T+
blocking-b2g: 1.3T? → 1.3T+
Attachment #8373157 - Flags: feedback?(vliu)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: