Bug 886110 looks like it'll need it, right Blake?

Comment on attachment 8364822 [details] [diff] [review] Add support for nullable dictionary return values in callbacks and js-implemented bindings. Review of attachment 8364822 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bindings/Codegen.py @@ +3870,5 @@ > > + if type.nullable(): > + dictLoc = "${declName}.SetValue()" > + else: > + dictLoc = "${declName}" I'd do: dictLoc = "${declName}" if type.nullable(): dictLoc += ".SetValue()" @@ +3878,5 @@ > exceptionCodeIndented.define())) > > + if type.nullable(): > + declType = CGTemplatedType("Nullable", declType) > + # XXXbz Should this check be isNullOrUndefined() instead? Given that the conversion from ECMAScript type to WebIDL type would work like that, I'd say yes.

Made those changes and pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/bbde82f0d314