Closed
Bug 966557
Opened 11 years ago
Closed 11 years ago
make nsIX509CertDB.ConstructX509Cert
Categories
(Core :: Security: PSM, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: mmc, Assigned: mmc)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
briansmith
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #928536 +++
See https://bugzilla.mozilla.org/show_bug.cgi?id=928536#c47.
Comment 1•11 years ago
|
||
No "FromRawDER" please.
Summary: make nsIX509CertDB.ConstructX509FromRawDER → make nsIX509CertDB.ConstructX509Cert
Assignee | ||
Comment 2•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mmc
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #8368988 -
Attachment is obsolete: true
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 8368992 [details] [diff] [review]
Add nsIX509CertDB.ConstructX509FromRawDER (
./mach xpcshell and ./mach gtest in security/manager/ssl work.
Attachment #8368992 -
Flags: review?(brian)
Comment 5•11 years ago
|
||
Comment on attachment 8368992 [details] [diff] [review]
Add nsIX509CertDB.ConstructX509FromRawDER (
Review of attachment 8368992 [details] [diff] [review]:
-----------------------------------------------------------------
::: security/manager/ssl/src/nsNSSCertificateDB.cpp
@@ +1427,5 @@
> +}
> +
> +/* nsIX509Cert constructX509 (in string certDER, unsigned long len); */
> +NS_IMETHODIMP
> +nsNSSCertificateDB::ConstructX509(const char *certDER,
const char* certDER,
@@ +1429,5 @@
> +/* nsIX509Cert constructX509 (in string certDER, unsigned long len); */
> +NS_IMETHODIMP
> +nsNSSCertificateDB::ConstructX509(const char *certDER,
> + uint32_t lengthDER,
> + nsIX509Cert **_retval)
nsIX509Cert** _retval)
@@ +1435,5 @@
> + nsNSSShutDownPreventionLock locker;
> + if (isAlreadyShutDown()) {
> + return NS_ERROR_NOT_AVAILABLE;
> + }
> + NS_ENSURE_ARG_POINTER(_retval);
https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style#Use_the_nice_macros
Attachment #8368992 -
Flags: review?(brian) → review+
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to Brian Smith (:briansmith, :bsmith; NEEDINFO? for response) from comment #5)
> https://developer.mozilla.org/en-US/docs/Developer_Guide/
> Coding_Style#Use_the_nice_macros
Time to switch to portrait mode on my laptop. Fixed and checking in.
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/af7bcffbbac9
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Component: Libraries → Security: PSM
Product: NSS → Core
Version: trunk → Trunk
Updated•11 years ago
|
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•