Closed
Bug 967298
Opened 11 years ago
Closed 11 years ago
make nsIX509CertList instantiable
Categories
(Core :: Security: PSM, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: mmc, Assigned: mmc)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
briansmith
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #966557 +++
+++ This bug was initially created as a clone of Bug #928536 +++
See https://bugzilla.mozilla.org/show_bug.cgi?id=928536#c51
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → mmc
Attachment #8369729 -
Flags: review?(dkeeler)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8369729 [details] [diff] [review]
certlist
Review of attachment 8369729 [details] [diff] [review]:
-----------------------------------------------------------------
::: security/manager/ssl/public/nsIX509CertList.idl
@@ +21,5 @@
> };
>
> %{C++
>
> +#define NS_X509CERTLIST_CID { /* 959fb165-6517-487f-ab9b-d8913be53197 */ \
NIT: fix alignment of "\".
::: security/manager/ssl/src/nsNSSCertificate.h
@@ +83,5 @@
> // certList is adopted
> nsNSSCertList(insanity::pkix::ScopedCERTCertList& certList,
> const nsNSSShutDownPreventionLock& proofOfLock);
>
> + // NULL constructor
You do not need this comment. (Also it would be "default" not "NULL".)
Attachment #8369729 -
Flags: review?(dkeeler) → review+
|
||
Updated•11 years ago
|
Component: Libraries → Security: PSM
Product: NSS → Core
Version: trunk → Trunk
|
|
Assignee | |
Comment 3•11 years ago
|
||
Fixed and checked in.
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/e99fd1631c09
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•